Require deployment manifest for trading Docker - #714
Merged
Conversation
…ployment-config # Conflicts: # trading/README.md
- Prevent stale registry data and actions during refresh failures - Preserve pending deployment state while configuration hydrates - Improve recovery errors, validation messages, and QA coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployments/local.jsonWhy
The previous default silently wrote
nulltodeployment.json, producing a demo-only image. Opening the normal markets route then failed at runtime with a missing deployment configuration message. A normal Docker build now requires real chain-specific deployment data and reports the missing prerequisite during the build instead.Validation
cd trading && bun test ./ts/tests/dockerCompose.test.ts— 3 passedbun run tsc— passedbun run format:check— passedcd trading && bun run format:check— passedbun run check:changed— passedcd trading && bunx @biomejs/biome check ts/tests/dockerCompose.test.ts README.md— passedbun run knip— passedgit diff --check— passedDocker execution was not available in the validation environment, so an end-to-end image build could not be run. The focused packaging test protects the Compose build argument, Dockerfile default, and missing-manifest check.
Review
origin/mainbefore commit (0 commits behind)