Reduce per-request allocation in ThreadSafeCookieStore.get()#2201
Merged
Conversation
hyperxpro
force-pushed
the
threadsafecookiestore-allocation
branch
from
97f3218 to
5b3a98e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
ThreadSafeCookieStore.get()ran aStream.filter().map().collect()pipeline per sub-domain level on every cookie-enabled request, allocating the pipeline, collector, and capturing lambdas each call.Modification:
Replaced the Stream pipeline with an imperative scan that appends matches straight into a single lazily-allocated result list.
Result:
Lower allocation and GC pressure on the cookie lookup path, which runs on every cookie-enabled request; returned cookies are unchanged.