refactor: unit converter parse as int #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
BigNumber equivalent here as well please @alexbarnsley |
Member
ignore, use |
alexbarnsley
changed the title
ItsANameToo
approved these changes
Feb 27, 2025
ItsANameToo
deleted the
refactor/transaction-builder-handle-strings-from-unit-converter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/86dw15f4f
Originally this PR was to handle strings as a type for passing values in to the
value,gas_priceandgas_limitmethods. Now UnitConverter has been updated to match the new PHP Crypto SDK where the UnitConverter#parse_units method returns an int which can be passed straight into one of the above methods.todo:
Checklist