Skip to content

feat: integrate multipayments #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ItsANameToo merged 26 commits into from
Feb 24, 2025
Merged

feat: integrate multipayments #152

ItsANameToo merged 26 commits into from
Feb 24, 2025

Conversation

@alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Feb 21, 2025 •
edited
Loading

Summary

https://app.clickup.com/t/86dvzxc3j

requires #151

This PR does a few things:

  • Multipayment integration
  • Fixes an issue with decoding array arguments (related to multipayment)
  • Fixes an issue with validating addresses when passed in as lowercase

TODO:

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alexbarnsley
update fixtures
0209ff4
@alexbarnsley
keccak integration
9214b03
@alexbarnsley
handle different contracts when deserializing
ab8ce08
@alexbarnsley
better handling of stripping 0x from data
79a35c3
@alexbarnsley
scrub
feecff0
@alexbarnsley
update other fixture data
15e922c
@alexbarnsley
fix wif test
029b9be
@alexbarnsley
move hardcoded tx values to fixtures
abe3f34
@alexbarnsley
deserialize test other contract transactions
3348de0
@alexbarnsley
update rpl decoder expectations
a1064a1
@alexbarnsley
remove unused transaction class
b144d17
@alexbarnsley
remove additional lstrips
a8a17a6
@alexbarnsley
made AbstractTransaction decode_payload method static
ee8ea60
@alexbarnsley
pass payload to tx type constructor to prevent double-up of decoding …
5655d2d 
…payload
@alexbarnsley
update multipayment address
3aa900c
@alexbarnsley
fix check for valid address
ec8f0e0
@alexbarnsley
add multipayment abi
9cab1f8
@alexbarnsley
test validating addresses
10c1f0c
@alexbarnsley
scrub
e9c37bb
@alexbarnsley
fix parameter decoder for arrays
448ed28
@alexbarnsley
feat: integrate multipayments
8c981d6
@alexbarnsley
test
003755c
@alexbarnsley alexbarnsley changed the base branch from feat/mainsail to refactor/keccak-adjustments February 21, 2025 01:55
Base automatically changed from refactor/keccak-adjustments to feat/mainsail February 21, 2025 11:38
@ItsANameToo
Copy link
Member

ItsANameToo commented Feb 21, 2025

some conflicts @alexbarnsley

@alexbarnsley alexbarnsley marked this pull request as ready for review February 24, 2025 11:49
@alexbarnsley
Copy link
Member Author

alexbarnsley commented Feb 24, 2025

@ItsANameToo resolved

@ItsANameToo ItsANameToo merged commit 5ad403c into feat/mainsail Feb 24, 2025
8 checks passed
@ItsANameToo ItsANameToo deleted the feat/integrate-multipayments branch February 24, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexbarnsley @ItsANameToo