Skip to content

Save button fix with Usage dialog popup#1304

Closed
OmkarSarkar204 wants to merge 5 commits intoArduPilot:masterfrom
OmkarSarkar204:mac-save-popup-fix
Closed

Save button fix with Usage dialog popup#1304
OmkarSarkar204 wants to merge 5 commits intoArduPilot:masterfrom
OmkarSarkar204:mac-save-popup-fix

Conversation

@OmkarSarkar204
Copy link
Contributor

@OmkarSarkar204 OmkarSarkar204 commented Feb 19, 2026

Follow-up PR of #1268.

Issue Still persists on new users on the Save and start configuration button.

Fix #1264

Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
@amilcarlucas
Copy link
Collaborator

This fix does a lot of changes, and it creates the risk of regressions on Windows and Linux.
Can you try to minimize the changes to the existing code?

@OmkarSarkar204
Copy link
Contributor Author

OmkarSarkar204 commented Feb 20, 2026

It's quite tricky, i tried many ways by adding, removing the grabset() but the button is still unresponsive, the main reason visibe is the "guidance popups" not showin before every new page.
I think, while the window calculates its position right now, it's accidentally allowing background processes to interrupt the UI while it's still trying to draw the window, which is what causing the issue.

Im thinking of blocking those interruptions by swapping update() for update_idletasks(), and ensure the grab_set() skip is strictly isolated to macOS.

Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
@OmkarSarkar204
Copy link
Contributor Author

@amilcarlucas, Can you please take a look at it if its ok now?

Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
@OmkarSarkar204
Copy link
Contributor Author

Hello @amilcarlucas , I resolved the merge conflict to update with the master branch. Tested it locally and also updated the test. Its working.

@amilcarlucas
Copy link
Collaborator

Thanks for continuing to work on this.
I do not like the amount of code that this PR adds. But I will review it this weekend. Thanks.

@amilcarlucas
Copy link
Collaborator

Closed in favor of the much simpler #1332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Save data and start configuration" button unresponsive on macOS

2 participants