Skip to content

Allow pre-selecting vehicle, version, and board via URL parameters #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanbasic1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow pre-selecting vehicle, version, and board via URL parameters #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 50 additions & 13 deletions web/static/js/add_build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,17 +302,32 @@ var rebuildConfig = {
versionId: null,
boardId: null,
selectedFeatures: [],
isRebuildMode: false
isRebuildMode: false,
fromUrlParams: false
};

async function init() {
if (typeof rebuildFromBuildId !== 'undefined') {
await initRebuild(rebuildFromBuildId);
} else {
initFromUrlParams();
Copy link
Member

@shiv-tyagi shiv-tyagi Feb 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename initRebuild to initPreSelect and do both in same function (and get rid of initFromUrlParams altogether). We first check if rebuild_from param is there, if not we check vehicle_id, board_id and version_id are present, and set those properties.

The only difference would be that we would not be setting selected_features[], in second case.

}

fetchVehicles();
}

function initFromUrlParams() {
const params = new URLSearchParams(window.location.search);
const hasParams = params.has('vehicle') || params.has('board') || params.has('version');

if (params.has('vehicle')) rebuildConfig.vehicleId = params.get('vehicle');
if (params.has('board')) rebuildConfig.boardId = params.get('board');
if (params.has('version')) rebuildConfig.versionId = params.get('version');
Comment on lines +323 to +325
Copy link
Member

@shiv-tyagi shiv-tyagi Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (params.has('vehicle')) rebuildConfig.vehicleId = params.get('vehicle');
if (params.has('board')) rebuildConfig.boardId = params.get('board');
if (params.has('version')) rebuildConfig.versionId = params.get('version');
if (params.has('vehicle_id')) rebuildConfig.vehicleId = params.get('vehicle');
if (params.has('board_id')) rebuildConfig.boardId = params.get('board');
if (params.has('version_id')) rebuildConfig.versionId = params.get('version');

Let us call it vehicle_id and similar at all places.


// Set flag to indicate URL parameters were provided
rebuildConfig.fromUrlParams = hasParams;
Copy link
Member

@shiv-tyagi shiv-tyagi Feb 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be avoided? This won't be needed if we have a common error handling as described in the other comment.

}

async function initRebuild(buildId) {
try {
const buildResponse = await fetch(`/api/v1/builds/${buildId}`);
Expand Down Expand Up @@ -361,6 +376,7 @@ function clearRebuildConfig() {
rebuildConfig.boardId = null;
rebuildConfig.selectedFeatures = [];
rebuildConfig.isRebuildMode = false;
rebuildConfig.fromUrlParams = false;
}

// enables or disables the elements with ids passed as an array
Expand Down Expand Up @@ -400,10 +416,17 @@ function fetchVehicles() {
if (rebuildConfig.vehicleId) {
const vehicleExists = all_vehicles.some(v => v.id === rebuildConfig.vehicleId);
if (!vehicleExists) {
console.warn(`Rebuild vehicle '${rebuildConfig.vehicleId}' not found in available vehicles`);
alert(`Warning: The vehicle from the original build is no longer available.\n\nRedirecting to new build page...`);
window.location.href = '/add_build';
return;
if (rebuildConfig.isRebuildMode) {
console.warn(`Rebuild vehicle '${rebuildConfig.vehicleId}' not found in available vehicles`);
alert(`Warning: The vehicle from the original build is no longer available.\n\nRedirecting to new build page...`);
window.location.href = '/add_build';
return;
} else if (rebuildConfig.fromUrlParams) {
console.warn(`URL parameter vehicle '${rebuildConfig.vehicleId}' not found. Defaulting to first available vehicle.`);
rebuildConfig.vehicleId = null;
} else {
rebuildConfig.vehicleId = null;
}
Comment on lines +419 to +429
Copy link
Member

@shiv-tyagi shiv-tyagi Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have one common error message for both cases? That way we can also avoid multiple if-else cases.

Maybe something like, "Vehicle XXX is no longer listed for building. Redirecting to new build page...".

}
}

Expand Down Expand Up @@ -442,10 +465,17 @@ function onVehicleChange(new_vehicle_id) {
if (rebuildConfig.versionId) {
const versionExists = all_versions.some(v => v.id === rebuildConfig.versionId);
if (!versionExists) {
console.warn(`Rebuild version '${rebuildConfig.versionId}' not found for vehicle '${new_vehicle_id}'`);
alert(`Warning: The version from the original build is no longer available.\n\nRedirecting to new build page...`);
window.location.href = '/add_build';
return;
if (rebuildConfig.isRebuildMode) {
console.warn(`Rebuild version '${rebuildConfig.versionId}' not found for vehicle '${new_vehicle_id}'`);
alert(`Warning: The version from the original build is no longer available.\n\nRedirecting to new build page...`);
window.location.href = '/add_build';
return;
} else if (rebuildConfig.fromUrlParams) {
console.warn(`URL parameter version '${rebuildConfig.versionId}' not found for vehicle '${new_vehicle_id}'. Defaulting to first available version.`);
rebuildConfig.versionId = null;
} else {
rebuildConfig.versionId = null;
}
Comment on lines +468 to +478
Copy link
Member

@shiv-tyagi shiv-tyagi Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the other comment for vehicles.

}
}

Expand Down Expand Up @@ -498,10 +528,17 @@ function onVersionChange(new_version) {
if (rebuildConfig.boardId) {
const boardExists = boards.some(b => b.id === rebuildConfig.boardId);
if (!boardExists) {
console.warn(`Rebuild board '${rebuildConfig.boardId}' not found for version '${version_id}'`);
alert(`Warning: The board from the original build is no longer available.\n\nRedirecting to new build page...`);
window.location.href = '/add_build';
return;
if (rebuildConfig.isRebuildMode) {
console.warn(`Rebuild board '${rebuildConfig.boardId}' not found for version '${version_id}'`);
alert(`Warning: The board from the original build is no longer available.\n\nRedirecting to new build page...`);
window.location.href = '/add_build';
return;
} else if (rebuildConfig.fromUrlParams) {
console.warn(`URL parameter board '${rebuildConfig.boardId}' not found for version '${version_id}'. Defaulting to first available board.`);
rebuildConfig.boardId = null;
} else {
rebuildConfig.boardId = null;
}
Comment on lines +531 to +541
Copy link
Member

@shiv-tyagi shiv-tyagi Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the other comment for vehicles.

}
}

Expand Down