Skip to content

web: allow failed builds artifact download from backend #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shiv-tyagi merged 1 commit into from
Feb 16, 2026
Merged

web: allow failed builds artifact download from backend #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/api/v1/builds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,15 +207,15 @@ async def download_artifact(

Raises:
404: Build not found
404: Artifact not available (build not completed successfully)
404: Artifact not available (build not completed)
"""
artifact_path = service.get_artifact_path(build_id)
if not artifact_path:
raise HTTPException(
status_code=404,
detail=(
f"Artifact not available for build '{build_id}'. "
"Build may not be completed or successful."
"Build may not be completed."
)
)
return FileResponse(
Expand Down
7 changes: 5 additions & 2 deletions web/services/builds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,11 @@ def get_artifact_path(self, build_id: str) -> Optional[str]:
if build_info is None:
return None

# Only return artifact if build was successful
if build_info.progress.state.name != "SUCCESS":
# Return early if build is still ongoing
if build_info.progress.state in [
build_manager.BuildState.PENDING,
build_manager.BuildState.RUNNING,
]:
return None

artifact_path = self.manager.get_build_archive_path(build_id)
Expand Down