Web: Fix CAN options visibility for non-CAN boards#227
Open
garvit000 wants to merge 1 commit intoArduPilot:mainfrom
Open
Web: Fix CAN options visibility for non-CAN boards#227garvit000 wants to merge 1 commit intoArduPilot:mainfrom
garvit000 wants to merge 1 commit intoArduPilot:mainfrom
Conversation
Member
|
Before I do a review, can you please tell did you test it? And what cases did you cover? Also, it is generally not recommended to close existing PRs without a good reason. We lose review history that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #151 where the "CAN" feature category remained visible even when selecting a board that does not support CAN.
Changes:
Test Plan:
Supersedes #209 with a cleaner implementation addressing all review feedback.
Closes #151