run sync tools with threads in call_func_async#73
Merged
Conversation
call_func_async
Collaborator
|
Nice! |
Collaborator
|
FYI @KeremTurgutlu it's best not to have both an issue and a PR, especially if they both have a label, otherwise we end up with both appearing in the changelog. If you want to add an issue to help track things, just leave it unlabelled. |
Contributor
Author
Didn't know about it, thanks for letting me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
call_func_asyncpreviously called sync functions directly on the event loop, blocking it and preventingasyncio.gatherfrom running multiple tool calls concurrently. Now sync functions are wrapped inasyncio.to_thread, enabling true parallel execution. Async functions are detected viainspect.iscoroutinefunctionand awaited directly as before.Fixes #72