[PWGEM] PhotonMeson: specify template parameter with concept if possible#14755
Merged
ktf merged 1 commit intoAliceO2Group:masterfrom Feb 4, 2026
Merged
[PWGEM] PhotonMeson: specify template parameter with concept if possible#14755ktf merged 1 commit intoAliceO2Group:masterfrom
ktf merged 1 commit intoAliceO2Group:masterfrom
Conversation
- Add usage of `o2::soa::is_iterator` and `o2::soa::is_table` as baseline whenever possible for template arguments to reduce compile time and increase code readability in Utils header and /bcWiseClusterSkimmer.cxx - Fix some function arguments not being const& when they should. This should speed up all tasks using `isGammaGammaDecay` since now it does not need to copy the whole mcparticle table everytime it is called.
mhemmer-cern
requested review from
alibuild,
dsekihat,
m-c-danisch,
mikesas,
novitzky and
rbailhac
as code owners
alibuild
approved these changes
Feb 2, 2026
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
fcolamar
pushed a commit
to fcolamar/O2Physics
that referenced
this pull request
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
o2::soa::is_iteratorando2::soa::is_tableas baseline whenever possible for template arguments to reduce compile time and increase code readability in Utils header and /bcWiseClusterSkimmer.cxxisGammaGammaDecaysince now it does not need to copy the whole mcparticle table everytime it is called.