Add also FLAC/MP3/WAV support for music and replace hardcoded "keeperNN.ogg" requirement with now automatic music file detection - #2
Open
AleWin32 wants to merge 1 commit into
Conversation
…ogg" requirement with now automatic music file detection
AleWin32
marked this pull request as ready for review
July 26, 2026 12:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for FLAC files (lossless compression) in addition to OGG (lossy compression), which is currently the only format KeeperFX supports.
This PR does not remove OGG support, it now adds FLAC, WAV and MP3 as well.
It also changes how tracks are located: the audio tracks are now read regardless of their filename (no fixed
keeperNN.oggpattern is expected), avoiding trouble for KeeperFX players who want to extract the audio themselves.The music folder is now listed and sorted by name in ascending order, so the tracks are always detected automatically.
Since tracks are usually extracted numbered by track, all of these naming patterns work:
It even works when the filenames don't contain the audio track number at all, or use numbering starting from 0 or 1, thanks to the ascending sort:
The preference is to preserve 100% of the original audio quality today while using as little storage space as possible.
Therefore, this is the preferred order in which the formats are attempted: