Skip to content

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 15, 2025

What is this pull request for?

Describe you pull request here...

Closes # (Remove if not related to any issue)

Notable changes (remove if none)

Explain any changes (maybe breaking?) that have been made.

Screenshots

Remove if no visual changes have been made.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

This has been broken for a long time now.

Signed-off-by: Thomas von Deyen <[email protected]>
Signed-off-by: Thomas von Deyen <[email protected]>
This allows to use only and except setting
on Picture ingredients like on File ingredients.

Signed-off-by: Thomas von Deyen <[email protected]>
@tvdeyen tvdeyen self-assigned this Dec 15, 2025
@tvdeyen tvdeyen added this to the 8.1 milestone Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.16%. Comparing base (aad0e7c) to head (b318d92).

Files with missing lines Patch % Lines
app/models/alchemy/picture.rb 66.66% 1 Missing ⚠️
...p/models/alchemy/storage_adapter/active_storage.rb 75.00% 1 Missing ⚠️
app/models/alchemy/storage_adapter/dragonfly.rb 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3522      +/-   ##
==========================================
- Coverage   97.19%   97.16%   -0.04%     
==========================================
  Files         287      287              
  Lines        7559     7579      +20     
==========================================
+ Hits         7347     7364      +17     
- Misses        212      215       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants