[fix] Converge the desktop session when a gate is answered elsewhere (11/12) by ardaerzin · Pull Request #5690 · Agenta-AI/agenta

ardaerzin · 2026-08-03T13:19:09Z

Context

Once a phone can answer approvals, the desktop tab looking at the same session has to notice. It did not: an approval answered elsewhere left the desktop showing "Approval needed to continue" until a manual reload, and sometimes after one.

Changes

Desktop settles a resumed turn's gate on replay and converges an open session through the watch relay from lane 9, refreshing the session before reopening a relay it finds dead.

Two backend correctness fixes sit underneath. Gates whose turn was consumed but never resolved are settled rather than orphaned as pending forever. And a displaced turn is treated as dead, which closes the parked-session lock ambiguity: previously a displaced turn's late heartbeat could re-arm a lock that a newer turn owned.

Mobile also renders assistant messages as markdown here, so a reply reads the same on both surfaces.

Tests / notes

The desktop changes are confined to AgentChatSlice hooks and the transcript adapter. Small diff, high scrutiny: this is the shared agent chat.
The lock fix has pytest coverage for the displaced-turn case specifically.

What to QA

Open a session on desktop and answer its approval from a phone. The desktop settles on its own, no reload.
Regression: answer an approval on desktop as before. Nothing about that flow changes.

vercel · 2026-08-03T13:19:14Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agenta-documentation	Ready	Preview	Aug 4, 2026 9:28pm

coderabbitai · 2026-08-03T13:19:17Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2fa74093-3a6b-4e9e-9c33-5ee022eb68ec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

ardaerzin · 2026-08-03T13:23:43Z

@coderabbitai review

coderabbitai · 2026-08-03T13:23:52Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

ardaerzin · 2026-08-03T17:55:12Z

@coderabbitai review

coderabbitai · 2026-08-03T17:55:18Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

ardaerzin · 2026-08-03T18:27:21Z

@coderabbitai review

coderabbitai · 2026-08-03T18:27:29Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

A turn approved elsewhere (e.g. from mobile) replayed as still parked: the durable record log carries the paused turn's interaction_request but no interaction_response, so the folded resume kept its tool part in approval-requested. The desktop adoption guard reads that as 'the server is parked too' and refused to adopt, leaving a reloaded session stuck on the pre-approval transcript with the approval dock up. Records that continue past a paused done mean the gate was answered (a deny settles its own part via tool_result denied), so settle whatever is left awaiting.

…h relay Subscribes the ACTIVE conversation to GET /sessions/streams/watch (the M3 SSE relay mobile already consumes) and, on records-changed, revalidates the durable records and re-applies the same guarded adoption the revalidate-on-open pass uses — so a turn that advances elsewhere lands in an open tab within seconds instead of only on reload. One foreground-only EventSource per panel, throttled, skipped while this tab streams; a fatal close retries every 60s and the reload path stays the fallback.

…solved A resume whose harness never re-raises the gate (cold replay, or a client-built resume that lands as a fresh turn) consumed the human's decision without transitioning the durable row, leaving it pending and forever actionable on every surface. The runner now settles those rows from the turn's in-band answers on every exit path, with the verdict the human gave, and the records worker cancels any gate whose turn reached a terminal record without pausing — guarded so a live park is never swept.

…biguity `alive` outlives its turn and a turn parked awaiting approval also clears `running`, so "alive held by another turn + no running" cannot tell a lapsed previous turn (a legitimate handover) from a live-but-parked one. Resolving it as a handover — which it must be, or every follow-up turn on a warm session aborts — let a zombie beat from an older turn take the nest of a parked session, after which the user's approval resume reported is_current_turn=false and aborted. Record what IS knowable at the moment it happens: every displacement (heartbeat handover, cancel, steer, kill, orphan sweep) now tombstones the turn it displaced, and a tombstoned turn's beats are refused before touching any lock or the stream row. A zombie is by definition a turn that already lost the nest, so `displaced => dead` is the discriminator the locks cannot provide. The ambiguous state keeps resolving as a handover; only a never-displaced turn can reach it. Also stops a superseded turn's is_running=false beat from clearing the LIVE turn's `running`, and a cancelled turn's beat from re-acquiring `alive`. The heartbeat wire is unchanged: `is_current_turn: false` already means "abort", so the runner needs no change and no restart.

Mobile showed assistant text through `whitespace-pre-wrap`, so a reply containing markdown displayed literal fences, `#` headings and `-` bullets. Desktop renders the same content properly. Adopt Streamdown (the renderer the mobile design and AI Elements already name) for assistant TEXT parts. User messages stay literal — markdown in your own words inside a bubble is surprising. Reasoning stays plain: it is collapsed by default and streams as fragments that incomplete-markdown repair would make flicker. - `isLiveTextItem` restricts incomplete-markdown repair to the one text item the stream is still appending to; settled text must not get it or a message legitimately ending in `**` is silently rewritten. - Streamdown's defaults are re-scaled to the app's 12px type ramp via descendant selectors, and its `sidebar` role (absent from the token bridge) is re-surfaced onto `muted`. Semantic tokens only. - Code blocks keep their own `overflow-x-auto`; the prose root wraps long unbroken tokens so the page body never scrolls horizontally. - Raw HTML is neutered by Streamdown's default rehype-raw -> rehype-sanitize -> rehype-harden pipeline; links get an explicit `rel="noopener noreferrer"`.

The SSE relay never told the client how long to wait before reconnecting, so the interval was implementation-defined — an API restart or deploy dropped every open stream and they all came back at once. The generator now leads with a `retry:` preamble (AGENTA_SESSIONS_WATCH_RETRY_ MILLISECONDS, default 5s), emitted after SUBSCRIBE so no event can land in an unsubscribed window between the client's `open` and the first frame.

At every access-token refresh boundary the whole client 401s for one round trip. The Fern/axios layers refresh and retry transparently; an EventSource has no interceptor, so the relay died and then sat blind for a fixed 60s — and a persistent failure retried on a flat cadence with no jitter. Both hooks now reopen on a jittered exponential backoff (1s → 30s, reset on `open`) and attempt a session refresh first, so an expired token costs seconds instead of a minute. Mobile also throttles the reconnect revalidation to the 3s desktop already used, so a reconnect loop can no longer fan out into one full records refetch per attempt (real `records-changed` events stay instant).

ardaerzin force-pushed the feat/effective-turn-config branch from 6101ac7 to f957a88 Compare August 3, 2026 15:13

ardaerzin force-pushed the fix/desktop-session-convergence branch from 28314ae to cc14c6a Compare August 3, 2026 15:13

vercel Bot deployed to Preview August 3, 2026 15:15 View deployment

ardaerzin force-pushed the feat/effective-turn-config branch from f957a88 to f34d0e1 Compare August 3, 2026 16:14

ardaerzin force-pushed the fix/desktop-session-convergence branch from cc14c6a to 0aa2522 Compare August 3, 2026 16:14

vercel Bot deployed to Preview August 3, 2026 16:16 View deployment

ardaerzin force-pushed the feat/effective-turn-config branch from f34d0e1 to 4223629 Compare August 3, 2026 16:47

ardaerzin force-pushed the fix/desktop-session-convergence branch from 0aa2522 to cfb9c84 Compare August 3, 2026 16:47

vercel Bot deployed to Preview August 3, 2026 16:49 View deployment

ardaerzin force-pushed the feat/effective-turn-config branch from 4223629 to fed6233 Compare August 3, 2026 17:34

ardaerzin force-pushed the fix/desktop-session-convergence branch from cfb9c84 to defca8b Compare August 3, 2026 17:34

vercel Bot deployed to Preview August 3, 2026 17:35 View deployment

ardaerzin force-pushed the feat/effective-turn-config branch from fed6233 to 0e3c2cb Compare August 3, 2026 17:54

ardaerzin force-pushed the fix/desktop-session-convergence branch from defca8b to de37daa Compare August 3, 2026 17:54

vercel Bot deployed to Preview August 3, 2026 17:55 View deployment

ardaerzin force-pushed the feat/effective-turn-config branch from 0e3c2cb to 86c74ff Compare August 3, 2026 18:26

ardaerzin force-pushed the fix/desktop-session-convergence branch from de37daa to 94e03ca Compare August 3, 2026 18:26

vercel Bot deployed to Preview August 3, 2026 18:28 View deployment

ardaerzin force-pushed the feat/effective-turn-config branch from 86c74ff to ea4d80e Compare August 3, 2026 20:04

ardaerzin force-pushed the fix/desktop-session-convergence branch from 94e03ca to 52d6e1f Compare August 3, 2026 20:04

vercel Bot deployed to Preview August 3, 2026 20:05 View deployment

ardaerzin force-pushed the feat/effective-turn-config branch from ea4d80e to e13f3f2 Compare August 3, 2026 22:29

ardaerzin force-pushed the fix/desktop-session-convergence branch from 52d6e1f to 4c08deb Compare August 3, 2026 22:29

vercel Bot deployed to Preview August 3, 2026 22:31 View deployment

ardaerzin force-pushed the feat/effective-turn-config branch from e13f3f2 to e1bd8b8 Compare August 4, 2026 18:26

ardaerzin force-pushed the fix/desktop-session-convergence branch from 4c08deb to 09c9335 Compare August 4, 2026 18:26

vercel Bot deployed to Preview August 4, 2026 18:28 View deployment

ardaerzin force-pushed the feat/effective-turn-config branch from e1bd8b8 to 2ddfa94 Compare August 4, 2026 19:26

ardaerzin force-pushed the fix/desktop-session-convergence branch from 09c9335 to 02fb123 Compare August 4, 2026 19:26

vercel Bot deployed to Preview August 4, 2026 19:28 View deployment

ardaerzin force-pushed the fix/desktop-session-convergence branch from 02fb123 to 24ac72c Compare August 4, 2026 20:27

vercel Bot deployed to Preview August 4, 2026 20:28 View deployment

ardaerzin added 7 commits August 4, 2026 23:37

ardaerzin force-pushed the feat/effective-turn-config branch from 2ddfa94 to d13945a Compare August 4, 2026 21:27

ardaerzin force-pushed the fix/desktop-session-convergence branch from 24ac72c to 02804ea Compare August 4, 2026 21:27

vercel Bot deployed to Preview August 4, 2026 21:28 View deployment

Navigation Menu

Uh oh!

[fix] Converge the desktop session when a gate is answered elsewhere (11/12) - #5690

[fix] Converge the desktop session when a gate is answered elsewhere (11/12)#5690
ardaerzin wants to merge 7 commits into
feat/effective-turn-configfrom
fix/desktop-session-convergence

ardaerzin commented Aug 3, 2026

Uh oh!

vercel Bot commented Aug 3, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

Review skipped

Uh oh!

ardaerzin commented Aug 3, 2026

Uh oh!

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

Uh oh!

ardaerzin commented Aug 3, 2026

Uh oh!

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

Uh oh!

ardaerzin commented Aug 3, 2026

Uh oh!

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

ardaerzin commented Aug 3, 2026

Context

Changes

Tests / notes

What to QA

Uh oh!

vercel Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

ardaerzin commented Aug 3, 2026

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ardaerzin commented Aug 3, 2026

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ardaerzin commented Aug 3, 2026

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Aug 3, 2026 •

edited

Loading

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading