Skip to content

[test] Sessions-rework release QA: plan, findings, gate extensions - #5546

Draft
mmabrouk wants to merge 7 commits into
feat/sessions-storage-reworkfrom
qa/sessions-release-gate
Draft

[test] Sessions-rework release QA: plan, findings, gate extensions#5546
mmabrouk wants to merge 7 commits into
feat/sessions-storage-reworkfrom
qa/sessions-release-gate

Conversation

@mmabrouk

Copy link
Copy Markdown
Member

Context

feat/sessions-storage-rework bundles the sessions storage rework plus the feature train stacked on it (server session list, concurrent approvals + batch UI, warm Stop and Steer, config drawer rework), about 600 files. Before release we needed to know what actually ships, whether the always-on surface regressed, and whether the flag-gated sessions train holds up beyond unit tests. The existing agent-release-gate skill only covered the flags-off legacy path and had gone stale in three places.

Changes

  • A QA plan with a filled execution log at docs/design/agent-workflows/projects/qa/release-2026-07-sessions-storage-rework.md. Every phase carries its verdict and evidence; the verdict summary at the bottom lists the issues found.
  • agent-release-gate skill refresh: the stale fingerprint invariant (now conditional on client mode), the outdated "frontend always echoes full history" claim, and dangling STATUS.md pointers are fixed; a new addendum documents the four session flags, their per-layer truthiness parsing, and the differential QA method.
  • Gate driver (qa_product.py): a --last-message-only mode that mirrors the frontend's minimal-history behavior and dumps the exact per-turn messages for offline diffing, plus three new journeys: records (durable-record readback with ordering and truncation assertions), sessions (REST lifecycle: query, archive, unarchive, rename, delete), and followup (post-approval-resume turn checking for duplicated tool-call records).
  • A new self-contained release-qa skill encoding the whole procedure (branch map, plan template, layered phases, stack-state discipline, evidence rules), with the template and a sanitized worked example as progressive-disclosure resources.

QA results (summary)

All wire, acceptance, migration, build, and depth checks passed. Full log in the plan doc. Findings filed as issues: #5542 (refresh while paused on an approval gate loses the gate; the sharpest one), #5543 (young-session delete resurrects), #5544 (config drawer what-changed gaps), #5545 (batch-approval UI unreachable on every harness), #5538 (keepalive teardown race after a same-session takeover), #5539 (concurrent-turn design characterization), #5534 (run.sh env-file tooling bug).

Tests / notes

  • The extended driver's journeys ran green against a live flags-on stack (11/11) and a flags-off stack (11/11); the differential legs and depth probes are documented in the plan doc.
  • The two skills are docs plus a test driver; no product code changes in this PR.
  • The UI screenshot recording is posted as a PR comment.

https://claude.ai/code/session_01VhviVuZExGJUnY28mzbPBK

mmabrouk added 7 commits July 28, 2026 16:48
…fresh, gate driver extensions

- QA plan + execution log for the v0.106 sessions release at
  docs/design/agent-workflows/projects/qa/release-2026-07-sessions-storage-rework.md
- agent-release-gate skill: fix stale fingerprint/agentRequest/STATUS.md references,
  document the four session flags and the differential QA method
- qa_product.py: --last-message-only differential mode with sent_messages dumps,
  new records/sessions/followup journeys

Claude-Session: https://claude.ai/code/session_01VhviVuZExGJUnY28mzbPBK
…tion procedure

Encodes the v0.106 sessions release QA method: branch map + harness audit first,
plan doc with execution log, layered phases (build/migration gate, flag-state wire
runs with differential diffs, mismatch cells, REST + acceptance, depth probes,
recorded browser pass), stack-state discipline, and evidence rules.

Claude-Session: https://claude.ai/code/session_01VhviVuZExGJUnY28mzbPBK
…disclosure

SKILL.md stays lean; the plan-doc template and a sanitized worked example ship
inside resources/ and load only at the step that needs them. Drops the external
docs-path dependency so the skill is shareable as one folder.

Claude-Session: https://claude.ai/code/session_01VhviVuZExGJUnY28mzbPBK
@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Jul 28, 2026 5:01pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a8e7a884-9abb-4892-881a-6e197db495a1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch qa/sessions-release-gate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mmabrouk

Copy link
Copy Markdown
Member Author

QA recording (watch first): qa-ui-pass-sessions-rework.mp4 — a 39-frame screenshot walkthrough of the browser pass (session rail, always-allow, warm Stop, Steer, the paused-gate-refresh defect, config drawer, Pi multi-gate approvals). Hosted as a draft-release asset; repo access required.

Per-scenario verdicts and evidence are in the plan doc's execution log in this PR. Defects found in the browser pass: #5542 (paused gate lost on refresh), #5543 (young-delete resurrection), #5544 (config drawer what-changed), #5545 (batch-approval UI unreachable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant