fix: sanitize project IDs derived from folder names with dots/special chars#2992
Open
vanshx999 wants to merge 1 commit into
Open
fix: sanitize project IDs derived from folder names with dots/special chars#2992vanshx999 wants to merge 1 commit into
vanshx999 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
ao startin a folder whose name contains dots (e.g.llama.cpp), the auto-derived project ID produces a session ID likellama.cpp-1that fails the session ID pattern[a-zA-Z0-9_-]+.This sanitizes the project ID at derivation time replacing any character outside
[a-zA-Z0-9_-]with a hyphen sollama.cppbecomesllama-cppand sessions are valid.Closes #1877