chore(ci): enable TypeScript typechecking in frontend CI workflow#2978
Open
sriram687 wants to merge 1 commit into
Open
chore(ci): enable TypeScript typechecking in frontend CI workflow#2978sriram687 wants to merge 1 commit into
chore(ci): enable TypeScript typechecking in frontend CI workflow#2978sriram687 wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for contributing to Agent Orchestrator. This PR is being picked up by the current external contributor on-call pair: If someone is already working on this, please continue as usual. For faster context or live questions, you can also join the AO Discord. Join the session here: Come by if you want to see what is being built, ask questions, or just hang around with the community. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables static TypeScript verification (
npm run typecheck) within theFrontendGitHub Actions workflow.Previously, TypeScript checking was intentionally bypassed because of pre-existing type errors in configuration files (such as
forge.config.tsand legacy updater modules). Those errors have been fully resolved in recent commits, andtsc --noEmitnow compiles with zero errors on themainbranch.Restoring this check ensures that new pull requests cannot merge type-safety regressions or compilation failures into
main, improving codebase stability.Changes
.github/workflows/frontend.yml:Typecheck projectstep runningnpm run typecheck(executestsc --noEmit) immediately after dependency installation (npm ci) in thetestjob.Verification
npm run typecheckverified locally: