Skip to content

chore(ci): enable TypeScript typechecking in frontend CI workflow#2978

Open
sriram687 wants to merge 1 commit into
AgentWrapper:mainfrom
sriram687:type-check
Open

chore(ci): enable TypeScript typechecking in frontend CI workflow#2978
sriram687 wants to merge 1 commit into
AgentWrapper:mainfrom
sriram687:type-check

Conversation

@sriram687

Copy link
Copy Markdown

Description

This PR enables static TypeScript verification (npm run typecheck) within the Frontend GitHub Actions workflow.
Previously, TypeScript checking was intentionally bypassed because of pre-existing type errors in configuration files (such as forge.config.ts and legacy updater modules). Those errors have been fully resolved in recent commits, and tsc --noEmit now compiles with zero errors on the main branch.
Restoring this check ensures that new pull requests cannot merge type-safety regressions or compilation failures into main, improving codebase stability.

Changes

  • .github/workflows/frontend.yml:
    • Removed outdated comments regarding legacy type errors.
    • Added the Typecheck project step running npm run typecheck (executes tsc --noEmit) immediately after dependency installation (npm ci) in the test job.

Verification

  • Clean run of npm run typecheck verified locally:
    > agent-orchestrator@0.10.3 typecheck
    > tsc --noEmit

Copilot AI review requested due to automatic review settings July 22, 2026 14:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@somewherelostt

Copy link
Copy Markdown
Collaborator

Thanks for contributing to Agent Orchestrator.

This PR is being picked up by the current external contributor on-call pair:

If someone is already working on this, please continue as usual.
The on-call pair is added for visibility, tracking, and support, not to take over the work.
If you need help with review, direction, reproduction, or next steps, please tag @illegalcall and @Pulkit7070 here.

For faster context or live questions, you can also join the AO Discord.

Join the session here:
https://discord.gg/H6ZDcUXmq

Come by if you want to see what is being built, ask questions, or just hang around with the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants