Skip to content

Update create-own-filters.md#828

Open
puglieri wants to merge 2 commits intomasterfrom
agm-2837-2839-fix-ad-filtering-article
Open

Update create-own-filters.md#828
puglieri wants to merge 2 commits intomasterfrom
agm-2837-2839-fix-ad-filtering-article

Conversation

@puglieri
Copy link
Contributor

No description provided.

Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 To request another review, post a new comment with "/windsurf-review".


1. Rules with the `$removeparam` modifier can only be used [**in trusted filters**](#trusted-filters).
1. `$removeparam` rules are compatible with [basic modifiers](#basic-rules-basic-modifiers), [content-type modifiers](#content-type-modifiers), and with the `$important` and `$app` modifiers. Rules with any other modifiers are considered invalid and will be discarded.
1. Although `$domain` is classified as a basic modifier, it is not compatible with the Manifest V3 extension.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a contradiction in the documentation. The compatibility table on line 399 indicates that the $domain modifier is supported in AdGuard for Chrome MV3 (with limitations), but the newly added note on line 2812 states that $domain is not compatible with the Manifest V3 extension. Please clarify which statement is correct and update the documentation accordingly.

@github-actions
Copy link

Preview was deployed to: https://pull-request-828.kb-adg.pages.dev/

@github-actions
Copy link

Preview was deployed to: https://pull-request-828.kb-adg.pages.dev/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant