Implement plugin loading callbacks and tracking for installed plugins #1558
+205
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lugins Signed-off-by: 7HR4IZ3 <[email protected]>
bajrangCoder
approved these changes
Aug 28, 2025
Contributor
|
? |
…tracking Signed-off-by: 7HR4IZ3 <[email protected]>
Signed-off-by: 7HR4IZ3 <[email protected]>
Author
|
Sorry about the late reply, forgot about this (wanted to use this feature in a plugin but I found a workaround) Updated the code, and ran the linter |
…INS set Signed-off-by: 7HR4IZ3 <[email protected]>
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a more robust plugin loading system with callbacks, tracking for installed and broken plugins, and loading timeouts. These are excellent additions that will improve the stability and user experience of the plugin system. I've identified one high-severity issue related to a potential memory leak in the plugin watcher cleanup and one medium-severity issue where code can be simplified. Overall, this is a valuable enhancement.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…watchers on failure Signed-off-by: 7HR4IZ3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce callbacks for plugin loading and completion, along with a mechanism to track installed plugins. This enhances the plugin management system by allowing asynchronous handling of plugin states.