Skip to content

fix: fallback to */* when accept attribute is absent in input type="file" #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajrangCoder merged 4 commits into from
Jan 19, 2025
Merged

fix: fallback to */* when accept attribute is absent in input type="file" #1154

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e17ce85
fix: use Ref instead of querrySelector follow up #1136
bajrangCoder Jan 9, 2025
b581e18
Merge branch 'Acode-Foundation:main' into main
bajrangCoder Jan 9, 2025
a9efb50
Merge branch 'Acode-Foundation:main' into main
bajrangCoder Jan 19, 2025
a166d24
fix: fallback to "*/*" when accept attribute is absent
bajrangCoder Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions src/plugins/browser/android/com/foxdebug/browser/Browser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,10 @@ public void onClick(View v) {
);

faviconFrame = new FrameLayout(context);
faviconFrameParams =
new LinearLayout.LayoutParams(
ViewGroup.LayoutParams.WRAP_CONTENT,
ViewGroup.LayoutParams.WRAP_CONTENT
);
faviconFrameParams = new LinearLayout.LayoutParams(
ViewGroup.LayoutParams.WRAP_CONTENT,
ViewGroup.LayoutParams.WRAP_CONTENT
);
faviconFrameParams.gravity = Gravity.CENTER_VERTICAL;
faviconFrame.setLayoutParams(faviconFrameParams);
faviconFrame.addView(favicon);
Expand Down Expand Up @@ -568,21 +567,24 @@ public boolean onShowFileChooser(
if (browser.filePathCallback != null) {
browser.filePathCallback.onReceiveValue(null);
}

browser.filePathCallback = filePathCallback;
Intent selectDocument = new Intent(Intent.ACTION_GET_CONTENT);
Boolean isMultiple =
(
fileChooserParams.getMode() ==
WebChromeClient.FileChooserParams.MODE_OPEN_MULTIPLE
);
String mimeType = fileChooserParams.getAcceptTypes()[0];

mimeType = mimeType == null ? "*/*" : mimeType;
String[] acceptTypes = fileChooserParams.getAcceptTypes();
String mimeType = "*/*"; // default if empty or null
if (acceptTypes != null && acceptTypes.length > 0) {
String firstType = acceptTypes[0];
if (firstType != null && !firstType.trim().isEmpty()) {
mimeType = firstType;
}
}

Intent selectDocument = new Intent(Intent.ACTION_GET_CONTENT);
selectDocument.addCategory(Intent.CATEGORY_OPENABLE);
selectDocument.setType(mimeType);

boolean isMultiple =
(fileChooserParams.getMode() ==
WebChromeClient.FileChooserParams.MODE_OPEN_MULTIPLE);
if (isMultiple) {
selectDocument.putExtra(Intent.EXTRA_ALLOW_MULTIPLE, true);
}
Expand Down
Loading