Fix MSAN use-of-uninitialized-value in av2_rd_pick_inter_mode_sb().#5083
Merged
Conversation
Initialize `ref_costs_single` for INTRA and TIP frame indices to `INT_MAX` when they are not allowed. Previously, these elements were left uninitialized in `estimate_ref_frame_costs` if the respective modes were not allowed, but they were still being read and passed to other functions in `av2_rd_pick_inter_mode_sb`, triggering MSAN warnings.
kslu-aom
approved these changes
Jul 7, 2026
yunqingwang1
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize
ref_costs_singlefor INTRA and TIP frame indices toINT_MAXwhen they are not allowed.Previously, these elements were left uninitialized in
estimate_ref_frame_costsif the respective modes were not allowed, but they were still being read and passed to other functions inav2_rd_pick_inter_mode_sb, triggering MSAN warnings.Fixes #5081