fix: remove unused import of maxtext_google from train.py#3200
Closed
kryvokhyzha wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Closed
fix: remove unused import of maxtext_google from train.py#3200kryvokhyzha wants to merge 1 commit intoAI-Hypercomputer:mainfrom
kryvokhyzha wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Conversation
bvandermoon
reviewed
Feb 20, 2026
Collaborator
bvandermoon
left a comment
There was a problem hiding this comment.
Thank you @kryvokhyzha for sending out this PR! We also have a fix going here: #3202
Contributor
Author
Thanks, I'll close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove import
from maxtext import maxtext_googlethat was introduced in commit4ef205efe3c4f31a700ff7621e7f1502575bd72c(merge of PR #3189).python3 -m maxtext.trainers.pre_train.trainfails immediately withImportError: cannot import name 'maxtext_google' from 'maxtext'. Nomaxtext_googlemodule exists in the open-source repo - it is a Google-internal side-effect import.# pylint: disable-next=unused-importandfrom maxtext import maxtext_google). The import was unused (pylint disable confirms this) and served only as an internal instrumentation hook.Error in commit
4ef205efe3c4f31a700ff7621e7f1502575bd72c:Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.