PR #3189: Migrate MaxText/train.py to maxtext/trainers/pre_train/train.py#3198
Open
bvandermoon wants to merge 1 commit intomainfrom
Open
PR #3189: Migrate MaxText/train.py to maxtext/trainers/pre_train/train.py#3198bvandermoon wants to merge 1 commit intomainfrom
bvandermoon wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…n.py Imported from GitHub PR #3189 * Move `MaxText/train.py` to `maxtext/trainers/pre_train/train.py` * Create shim in `MaxText/train.py` to support old command. Include a deprecation warning * TODO: Add deprecation dates to this and other shims we are adding * Update all old path references in repo * Left off links to old file that include a specific commit. Can be found by searching this regex: `https://github\.com/AI-Hypercomputer/maxtext/.*trainers/pre_train/train`. We can choose to update these links later once the commit id of the actually merged PR is available Both new and old commands are working as expected: New command: ``` python3 -m maxtext.trainers.pre_train.train src/maxtext/configs/base.yml \ run_name=<run_name> \ base_output_directory=gs://<gcs_bucket> \ dataset_type=synthetic \ steps=10 \ enable_checkpointing=false ``` Old command: ``` python3 -m MaxText.train src/maxtext/configs/base.yml \ run_name=<run_name> \ base_output_directory=gs://<gcs_bucket> \ dataset_type=synthetic \ steps=10 \ enable_checkpointing=false ``` Before submitting this PR, please make sure (put X in square brackets): - [x] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [x] I have necessary comments in my code, particularly in hard-to-understand areas. - [x] I have run end-to-end tests tests and provided workload links above if applicable. - [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in [our documentation](https://maxtext.readthedocs.io/en/latest/development.html#adding-new-documentation-files). Copybara import of the project: -- 3532d64 by Branden Vandermoon <bvandermoon@google.com>: Migrate MaxText/train.py to maxtext/trainers/pre_train/train.py Merging this change closes #3189 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3189 from AI-Hypercomputer:bvandermoon-restructure 3532d64 PiperOrigin-RevId: 872503713
8ffb222 to
ae9574e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3189: Migrate MaxText/train.py to maxtext/trainers/pre_train/train.py
Imported from GitHub PR #3189
Description
MaxText/train.pytomaxtext/trainers/pre_train/train.pyMaxText/train.pyto support old command. Include a deprecation warninghttps://github\.com/AI-Hypercomputer/maxtext/.*trainers/pre_train/train. We can choose to update these links later once the commit id of the actually merged PR is availableTests
Both new and old commands are working as expected:
New command:
Old command:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.Copybara import of the project:
--
3532d64 by Branden Vandermoon bvandermoon@google.com:
Migrate MaxText/train.py to maxtext/trainers/pre_train/train.py
Merging this change closes #3189
FUTURE_COPYBARA_INTEGRATE_REVIEW=#3189 from AI-Hypercomputer:bvandermoon-restructure 3532d64