Conversation
257e3fe to
510e955
Compare
|
🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
🤖 I'm sorry @RissyRan, but I was unable to process your request. Please see the logs for more details. |
There was a problem hiding this comment.
Thank you! There were some attention autoregressive/decoding tests:
- mha:
maxtext/tests/unit/attention_test.py
Line 371 in 3fbe3be
- mla:
maxtext/tests/unit/attention_test.py
Line 1195 in 3fbe3be
Shall we add a similar one to test indexer cache in mla? example from gemini
a470971 to
9f2ba53
Compare
9f2ba53 to
7414d69
Compare
Sounds good. Also enabled the mla assertion, and did some sanity check for decoding: long seq, short seq |
Description
Enable Indexer cache for DS v3.2 decoding, to unblock the eval benchmark for DS v3.2 model with sparse attention bringup.
init_indexer_cache&update_indexer_cachefor indexer cacheTests
max_prefill_predict_length=3072 max_target_length=4096: linkChecklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.