Add prompt preprocessing and token placeholders for Omni#3062
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 21, 2026
Merged
Add prompt preprocessing and token placeholders for Omni#3062copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
0852636 to
cc3e660
Compare
a31e991 to
1383fcf
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
entrpn
approved these changes
Feb 10, 2026
aireenmei
reviewed
Feb 10, 2026
1392e74 to
2fcffaf
Compare
1a100e9 to
4073136
Compare
aireenmei
approved these changes
Feb 20, 2026
4073136 to
d15007f
Compare
d37c2bb to
5e78bbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Collaborate with original author: @eitanporat at PR #2731.
reformat_prompt_qwen3_omnifor prompt template.get_mm_offsets_qwen3_omnito compute multimodal token lengths.prepare_text_for_image_fusion, acceptingconfigso it allows more complicated placeholder formatting by using model-specific config fields.Tests
Follow up in e2e tests in #2729
Added two more test asserts in
qwen3_omni_layers_test.py:Prompt (with placeholders): https://paste.googleplex.com/6444051776798720
Tokenized prompt (with placeholders): https://diff.googleplex.com/#key=v8U2Vrap2cyR
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.