Skip to content

Move Maxtext layers and models.#3054

Open
dipannita08 wants to merge 1 commit intomainfrom
move-maxtext-layers-2
Open

Move Maxtext layers and models.#3054
dipannita08 wants to merge 1 commit intomainfrom
move-maxtext-layers-2

Conversation

@dipannita08
Copy link
Collaborator

@dipannita08 dipannita08 commented Jan 30, 2026 •
edited
Loading

Description

Move maxtext layers and models.

Tests

  • Unit tests
  • Github CI

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Jan 30, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 96.58537% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/layers/encoders.py 33.33% 4 Missing ⚠️
src/MaxText/layerwise_quantization.py 0.00% 2 Missing ⚠️
src/MaxText/integration/tunix/tunix_adapter.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

SurbhiJainUSC
SurbhiJainUSC reviewed Jan 30, 2026
View reviewed changes
@dipannita08 dipannita08 force-pushed the move-maxtext-layers-2 branch from 3cf7126 to 38e28fd Compare February 6, 2026 04:53
@dipannita08 dipannita08 changed the title Move src/MaxText/layers to src/maxtext/layers Move src/MaxText/layers to src/maxtext/layers and src/maxtext/models Feb 6, 2026
@dipannita08 dipannita08 force-pushed the move-maxtext-layers-2 branch from 38e28fd to 737f520 Compare February 6, 2026 06:00
@dipannita08 dipannita08 changed the title Move src/MaxText/layers to src/maxtext/layers and src/maxtext/models Move Maxtext layers and models. Feb 6, 2026
@dipannita08 dipannita08 force-pushed the move-maxtext-layers-2 branch from 9010038 to 581c5d3 Compare February 7, 2026 00:24
bvandermoon
bvandermoon reviewed Feb 10, 2026
View reviewed changes
Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

@dipannita08 dipannita08 force-pushed the move-maxtext-layers-2 branch 4 times, most recently from ff42f6b to e403509 Compare February 13, 2026 00:47
@dipannita08 dipannita08 force-pushed the move-maxtext-layers-2 branch from e403509 to d13a3a3 Compare February 18, 2026 02:24
@dipannita08 dipannita08 force-pushed the move-maxtext-layers-2 branch from d13a3a3 to 18754ef Compare February 19, 2026 03:51
@dipannita08 dipannita08 force-pushed the move-maxtext-layers-2 branch from d25d480 to ac6ba4a Compare February 19, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SurbhiJainUSC SurbhiJainUSC SurbhiJainUSC left review comments

@bvandermoon bvandermoon bvandermoon approved these changes

@khatwanimohit khatwanimohit khatwanimohit approved these changes

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@mitalisi mitalisi Awaiting requested review from mitalisi mitalisi is a code owner

@gpolovets1 gpolovets1 Awaiting requested review from gpolovets1 gpolovets1 is a code owner

@mailvijayasingh mailvijayasingh Awaiting requested review from mailvijayasingh mailvijayasingh is a code owner

@jrplatin jrplatin Awaiting requested review from jrplatin jrplatin is a code owner

@patemotter patemotter Awaiting requested review from patemotter patemotter is a code owner

@Lumosis Lumosis Awaiting requested review from Lumosis Lumosis is a code owner

@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner

@jshin1394 jshin1394 Awaiting requested review from jshin1394 jshin1394 is a code owner

@liudangyi liudangyi Awaiting requested review from liudangyi liudangyi is a code owner

@shralex shralex Awaiting requested review from shralex shralex is a code owner

@parambole parambole Awaiting requested review from parambole parambole is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

@gagika gagika Awaiting requested review from gagika gagika is a code owner

@michelle-yooh michelle-yooh Awaiting requested review from michelle-yooh michelle-yooh is a code owner

@suexu1025 suexu1025 Awaiting requested review from suexu1025 suexu1025 is a code owner

@jesselu-google jesselu-google Awaiting requested review from jesselu-google jesselu-google is a code owner

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

@shuningjin shuningjin Awaiting requested review from shuningjin shuningjin is a code owner

@jiangjy1982 jiangjy1982 Awaiting requested review from jiangjy1982 jiangjy1982 is a code owner

@NicoGrande NicoGrande Awaiting requested review from NicoGrande NicoGrande is a code owner

@hengtaoguo hengtaoguo Awaiting requested review from hengtaoguo hengtaoguo is a code owner

@A9isha A9isha Awaiting requested review from A9isha A9isha is a code owner

@aireenmei aireenmei Awaiting requested review from aireenmei aireenmei is a code owner

@NuojCheng NuojCheng Awaiting requested review from NuojCheng NuojCheng is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

pull ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dipannita08 @SurbhiJainUSC @bvandermoon @khatwanimohit

Comments