THREESCALE-14267 Add 3 status conditions; Use new status for requeue#1155
Open
urbanikb wants to merge 2 commits into3scale:masterfrom
Open
THREESCALE-14267 Add 3 status conditions; Use new status for requeue#1155urbanikb wants to merge 2 commits into3scale:masterfrom
urbanikb wants to merge 2 commits into3scale:masterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1155 +/- ##
==========================================
+ Coverage 41.84% 43.16% +1.31%
==========================================
Files 203 203
Lines 20859 20885 +26
==========================================
+ Hits 8729 9015 +286
+ Misses 11350 11056 -294
- Partials 780 814 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
urbanikb
force-pushed
the
THREESCALE-14267
branch
2 times, most recently
from
e9384ab to
a1878ac
Compare
urbanikb
force-pushed
the
THREESCALE-14267
branch
3 times, most recently
from
08bb744 to
3f10de5
Compare
tkan145
requested changes
Apr 16, 2026
urbanikb
force-pushed
the
THREESCALE-14267
branch
from
3f10de5 to
c24fea0
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
urbanikb
force-pushed
the
THREESCALE-14267
branch
from
c24fea0 to
3e09410
Compare
tkan145
previously approved these changes
Apr 17, 2026
Contributor
tkan145
left a comment
tkan145
left a comment
There was a problem hiding this comment.
Tested with both fresh installations and upgrades, the code works perfectly.
/lgtm
/approve
tkan145
dismissed
their stale review
Sorry but can you also update the doc here?
https://github.com/3scale/3scale-operator/blob/master/doc/apimanager-reference.md#conditionspec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
What
Previously, APIManager exposed a single Available condition that collapsed three independent system checks into one opaque signal. When
Available=Falsethere was no way to tell from the CR alone whether the problem was with deployments, routes, or secrets.New conditions
Three independent sub-conditions are now present in
.status.conditions:DeploymentsAvailableRoutesReadySecretsAvailableAvailable remains a roll-up: True if all above sub-conditions are True.
Change in status reporting
Before: On a broken install you would see:
After: The root cause is visible without inspecting cluster resources:
Backwards compatibility
The Available condition continues to surface Reason and Message from SecretsAvailable when secrets are missing, preserving existing automation that reads those fields from Available.
Verification
Tested that the status behaves as expected (namespace
3scale-abcbelow).Also verified that if a different version of operator (earlier 2.16 from public bundle) is installed in a different namespace (namespace
3scale-parallel), it will be able to set status on the CR in that namespace.