pass status_code to FailedToRetrieveItemException#144
Open
yashpy wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to address issue #129 by making FailedToRetrieveItemException more machine-actionable, specifically by ensuring callers can access an HTTP status code without parsing the exception message.
Changes:
- Pass
status_code=response.status_codewhen raisingFailedToRetrieveItemExceptioninget_item_by_title. - Pass
status_code=response.status_codewhen raisingFailedToRetrieveItemExceptioninget_items.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
179
to
184
| except HTTPError: | ||
| raise FailedToRetrieveItemException( | ||
| f"Unable to retrieve items. Received {response.status_code} \ | ||
| for {url} with message: {response.json().get('message')}" | ||
| for {url} with message: {response.json().get('message')}", | ||
| status_code=response.status_code | ||
| ) |
Comment on lines
218
to
223
| except HTTPError: | ||
| raise FailedToRetrieveItemException( | ||
| f"Unable to retrieve items. Received {response.status_code} \ | ||
| for {url} with message: {response.json().get('message')}" | ||
| for {url} with message: {response.json().get('message')}", | ||
| status_code=response.status_code | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129