Skip to content

fix(phpcs): exclude vendor/ from ruleset to silence third-party errors #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faisalahammad wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

fix(phpcs): exclude vendor/ from ruleset to silence third-party errors #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Exclude `vendor/` from the PHPCS ruleset so PHPCompatibility no longer reports issues in third-party dependencies (`nikic/php-parser`, `hamcrest/hamcrest-php`) on PHP 8.2+
- Switch `testVersion` in the PHPCS ruleset from exact `7.4` to open range `7.4-` so the standard targets the minimum supported PHP and above

## [1.1.1](https://github.com/10up/wp_mock/compare/1.1.0...1.1.1) - 2025-12-03
### Fixed
- Address PHP deprecation warnings about implicitly nullable parameters
Expand Down
6 changes: 4 additions & 2 deletions phpcs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
<?xml version="1.0"?>
<ruleset name="Custom ruleset">
<description>WP_Mock PHPCS ruleset. Scans project source only; vendor/ is excluded so third-party code is never reported.</description>
<file>./php</file>
<file>./tests</file>
<exclude-pattern>*/vendor/*</exclude-pattern>
<arg value="sp"/>
<rule ref="PHPCompatibility"/>
<config name="testVersion" value="7.4"/>
</ruleset>
<config name="testVersion" value="7.4-"/>
</ruleset>