fix/4191: Search template generation when Post Search feature is disabled#4297
Open
Sidsector9 wants to merge 2 commits intodevelopfrom
Open
fix/4191: Search template generation when Post Search feature is disabled#4297Sidsector9 wants to merge 2 commits intodevelopfrom
Sidsector9 wants to merge 2 commits intodevelopfrom
Conversation
Member
|
Wouldn't it make more sense to make Instant Results dependent on the Post Search feature? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Instant Results failed to generate a search template when the Post Search feature was disabled. The Post indexable was never activated, so the query in
get_search_template()fell back to MySQL instead of Elasticsearch and no template was captured.Closes #4191
How to test the Change
Changelog Entry
Credits
Props @burhandodhy @Sidsector9
Checklist: