refactor: use CodeBuilder#187
Closed
igamigo wants to merge 3 commits into
Closed
Conversation
igamigo
force-pushed
the
igamigo-codebuilder-instead
branch
from
1dc5812 to
bf7b76d
Compare
partylikeits1983
approved these changes
Apr 20, 2026
Keinberger
force-pushed
the
kbg/chore/v14-migration
branch
from
5a5331d to
9c1fd93
Compare
igamigo
force-pushed
the
igamigo-codebuilder-instead
branch
from
bf7b76d to
b56a4f4
Compare
Keinberger
force-pushed
the
kbg/chore/v14-migration
branch
2 times, most recently
from
12b0262 to
63cc332
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Official guidance should be to utilize the
CodeBuilder, which is also provided byClient. Recently mixing source managers in assemblers started resulting in internal panics (0xMiden/miden-vm#2778), so we need to make guidance as consistent as possible. This also simplifies code a bunch. cc @Keinberger @BrianSeong99Closes #188.