chore: Rename NoteMetadata to PartialNoteMetadata#2887
Merged
Conversation
Also optimizes metadata header serialization.
…-attachments-getters
…e-note-attachments-getters
…-multiple-note-attachments-followup
bobbinth
approved these changes
May 12, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of optional nits inline.
Base automatically changed from
pgackst-multiple-note-attachments-followup
to
next
May 12, 2026 09:36
* Note lifecycle assertion macros * Replace chain/tx assert macros with helper methods Address comments from the issuse #2805, drop the 4 macros in favor of plain helper methods. - `assert_note_committed!` -> `MockChain::is_note_committed` - `assert_note_unspent!` -> `MockChain::is_note_unspent` - `assert_note_consumed!` -> `MockChain::is_note_consumed` - `assert_note_consumed_by!` -> `ExecutedTransaction::consumes_note` Keep `assert_note_created!` since it does spec matching with optional fields.
* fix(protocol): encode note metadata v1 as one * fix(protocol): import ToString in metadata tests * docs(protocol): clarify account id version checks --------- Co-authored-by: Bobbin Threadbare <43513081+bobbinth@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
NoteMetadatatoPartialNoteMetadataandNoteMetadataHeadertoNoteMetadataas motivated in #2874 (comment).Small change sneaked in: Simplifies
BatchNoteTreeandBlockNoteTreeconstructors to takeNoteHeaderinstead ofNoteId+NoteMetadata.closes #2874