Skip to content

Commit 1c59bca

Browse files
committed
changed statementclientexception to add status code prop. Also updated testcontainers and revealed some old bad dependencies for junit
1 parent 83927e8 commit 1c59bca

10 files changed

Lines changed: 44 additions & 20 deletions

File tree

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@
117117
<dependency>
118118
<groupId>org.testcontainers</groupId>
119119
<artifactId>testcontainers</artifactId>
120-
<version>1.20.6</version>
120+
<version>2.0.5</version>
121121
<scope>test</scope>
122122
</dependency>
123123
</dependencies>

src/main/java/com/yetanalytics/xapi/client/StatementClient.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ private List<UUID> doPost(List<Statement> statements, URI endpoint)
7979
EntityUtils.consumeQuietly(response.getEntity());
8080
throw new StatementClientException(String.format(
8181
"Error, Non-200 Status. Received: %s",
82-
response.getStatusLine().getStatusCode()));
82+
response.getStatusLine().getStatusCode()),
83+
response.getStatusLine().getStatusCode());
8384
}
8485
}
8586

@@ -107,7 +108,7 @@ public List<UUID> postStatements(List<Statement> stmts) {
107108
}
108109
return result;
109110
} catch (ParseException | IOException e) {
110-
throw new StatementClientException("Error posting Statements", e);
111+
throw new StatementClientException("Error posting Statements", 0, e);
111112
}
112113
}
113114

@@ -123,7 +124,8 @@ private StatementResult doGetStatementResult(URI endpoint)
123124
EntityUtils.consumeQuietly(response.getEntity());
124125
throw new StatementClientException(String.format(
125126
"Error, Non-200 Status. Received: %s",
126-
response.getStatusLine().getStatusCode()));
127+
response.getStatusLine().getStatusCode()),
128+
response.getStatusLine().getStatusCode());
127129
}
128130
}
129131

@@ -139,7 +141,8 @@ private Statement doGetStatement(URI endpoint)
139141
EntityUtils.consumeQuietly(response.getEntity());
140142
throw new StatementClientException(String.format(
141143
"Error, Non-200 Status. Received: %s",
142-
response.getStatusLine().getStatusCode()));
144+
response.getStatusLine().getStatusCode()),
145+
response.getStatusLine().getStatusCode());
143146
}
144147
}
145148

@@ -195,7 +198,7 @@ public List<Statement> getStatements(StatementFilters filters, Integer max) {
195198
}
196199

197200
} catch (IOException e) {
198-
throw new StatementClientException("Error getting Statements", e);
201+
throw new StatementClientException("Error getting Statements", 0, e);
199202
}
200203
return statements;
201204
}

src/main/java/com/yetanalytics/xapi/exception/StatementClientException.java

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package com.yetanalytics.xapi.exception;
22

33
public class StatementClientException extends RuntimeException {
4+
5+
private Integer statusCode;
46

57
public StatementClientException() {
68
super();
@@ -10,14 +12,33 @@ public StatementClientException(String message) {
1012
super(message);
1113
}
1214

15+
public StatementClientException(String message, Integer status) {
16+
super(message);
17+
this.statusCode = status;
18+
}
19+
1320
public StatementClientException(String message, Throwable cause) {
1421
super(message, cause);
1522
}
1623

24+
public StatementClientException(String message, Integer status, Throwable cause) {
25+
super(message, cause);
26+
this.statusCode = status;
27+
}
28+
1729
public StatementClientException(Throwable cause) {
1830
super(cause);
1931
}
2032

33+
public StatementClientException(Integer status, Throwable cause) {
34+
super(cause);
35+
this.statusCode = status;
36+
}
37+
38+
public Integer getStatusCode() {
39+
return statusCode;
40+
}
41+
2142
@Override
2243
public String getMessage() {
2344
return "StatementClientException: " + super.getMessage();

src/test/java/com/yetanalytics/model/ActivityDefinitionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import java.util.HashMap;
77
import java.util.List;
88

9-
import static org.junit.Assert.assertTrue;
9+
import static org.junit.jupiter.api.Assertions.assertTrue;
1010
import org.junit.jupiter.api.BeforeEach;
1111
import org.junit.jupiter.api.Test;
1212

src/test/java/com/yetanalytics/model/StatementTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import java.util.List;
77
import java.util.UUID;
88

9-
import static org.junit.Assert.assertTrue;
9+
import static org.junit.jupiter.api.Assertions.assertTrue;
1010
import org.junit.jupiter.api.BeforeEach;
1111
import org.junit.jupiter.api.Test;
1212
import org.semver4j.Semver;

src/test/java/com/yetanalytics/xapi/client/StatementClientTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package com.yetanalytics.xapi.client;
22

3-
import static org.junit.Assert.assertEquals;
4-
import static org.junit.Assert.assertNotNull;
5-
import static org.junit.Assert.assertTrue;
3+
import static org.junit.jupiter.api.Assertions.assertEquals;
4+
import static org.junit.jupiter.api.Assertions.assertNotNull;
5+
import static org.junit.jupiter.api.Assertions.assertTrue;
66

77
import java.io.File;
88
import java.io.IOException;

src/test/java/com/yetanalytics/xapi/client/filters/StatementFiltersTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.yetanalytics.xapi.client.filters;
22

3-
import static org.junit.Assert.assertEquals;
4-
import static org.junit.Assert.assertNotNull;
3+
import static org.junit.jupiter.api.Assertions.assertEquals;
4+
import static org.junit.jupiter.api.Assertions.assertNotNull;
55

66
import java.net.URI;
77
import java.util.UUID;

src/test/java/com/yetanalytics/xapi/model/LangTagTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import java.util.IllformedLocaleException;
44

5-
import static org.junit.Assert.assertEquals;
6-
import static org.junit.Assert.assertNotNull;
7-
import static org.junit.Assert.assertThrows;
5+
import static org.junit.jupiter.api.Assertions.assertEquals;
6+
import static org.junit.jupiter.api.Assertions.assertNotNull;
7+
import static org.junit.jupiter.api.Assertions.assertThrows;
88
import org.junit.jupiter.api.Test;
99

1010
public class LangTagTest {

src/test/java/com/yetanalytics/xapi/util/StatementValidatorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package com.yetanalytics.xapi.util;
22

3-
import static org.junit.Assert.assertTrue;
3+
import static org.junit.jupiter.api.Assertions.assertTrue;
44

55
import java.util.Set;
66

7-
import org.junit.Test;
7+
import org.junit.jupiter.api.Test;
88

99
import com.yetanalytics.xapi.model.Activity;
1010
import com.yetanalytics.xapi.model.LangTag;

src/test/java/com/yetanalytics/xapi/util/ValidationUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.yetanalytics.xapi.util;
22

3-
import static org.junit.Assert.assertEquals;
4-
import static org.junit.Assert.assertTrue;
3+
import static org.junit.jupiter.api.Assertions.assertEquals;
4+
import static org.junit.jupiter.api.Assertions.assertTrue;
55

66
import jakarta.validation.Validation;
77
import jakarta.validation.Validator;

0 commit comments

Comments
 (0)