Description
After LSP features are fully implemented and tested, remove the redundant direct editor implementations that have been replaced by LSP equivalents.
Scope
Files to Remove (once LSP equivalents are verified)
From com.vogella.ide.editor.asciidoc:
AsciidocContentAssistProcessor.java - replaced by LSP completion
IncludeHyperlinkDetector.java - replaced by LSP document links
ImageHyperlinkDetector.java - replaced by LSP document links
LinkHyperlinkDetector.java - replaced by LSP document links
ResourceHyperlink.java - replaced by LSP navigation
ImageHover.java - replaced by LSP hover
Extension Point Registrations to Remove
From com.vogella.ide.editor.asciidoc/plugin.xml:
org.eclipse.ui.genericeditor.contentAssistProcessors registration
org.eclipse.ui.workbench.texteditor.hyperlinkDetectors registrations (3x)
org.eclipse.ui.genericeditor.hoverProviders registration
Files/Features to KEEP
- TextMate grammar (
syntaxes/asciidoc.json)
- Language configuration (
language-configurations/asciidoc.json)
- Compare/merge viewer (
AsciidocMergeViewer.java, etc.)
- Content type definitions
- Editor icon
Test Migration Strategy
Before removal:
- Create feature flag or preference to toggle between editor/LSP implementations
- Run all existing tests against LSP implementation
- Verify feature parity with original implementation
- Get user feedback on LSP version
Testing After Removal
Dependencies
All Phase 1 issues must be completed and verified:
Priority: Low (do last)
Estimated Effort: 1-2 days
Description
After LSP features are fully implemented and tested, remove the redundant direct editor implementations that have been replaced by LSP equivalents.
Scope
Files to Remove (once LSP equivalents are verified)
From
com.vogella.ide.editor.asciidoc:AsciidocContentAssistProcessor.java- replaced by LSP completionIncludeHyperlinkDetector.java- replaced by LSP document linksImageHyperlinkDetector.java- replaced by LSP document linksLinkHyperlinkDetector.java- replaced by LSP document linksResourceHyperlink.java- replaced by LSP navigationImageHover.java- replaced by LSP hoverExtension Point Registrations to Remove
From
com.vogella.ide.editor.asciidoc/plugin.xml:org.eclipse.ui.genericeditor.contentAssistProcessorsregistrationorg.eclipse.ui.workbench.texteditor.hyperlinkDetectorsregistrations (3x)org.eclipse.ui.genericeditor.hoverProvidersregistrationFiles/Features to KEEP
syntaxes/asciidoc.json)language-configurations/asciidoc.json)AsciidocMergeViewer.java, etc.)Test Migration Strategy
Before removal:
Testing After Removal
Dependencies
All Phase 1 issues must be completed and verified:
Priority: Low (do last)
Estimated Effort: 1-2 days