diff --git a/src/core/notebook.cpp b/src/core/notebook.cpp index 203ca22..d17f79e 100644 --- a/src/core/notebook.cpp +++ b/src/core/notebook.cpp @@ -133,6 +133,8 @@ Notebook::Notebook(const std::string &local_data_folder, const std::string &root NotebookType type) : local_data_folder_(local_data_folder), root_folder_(root_folder), type_(type) {} +Notebook::~Notebook() = default; + void Notebook::EnsureId() { if (config_.id.empty()) { config_.id = GenerateUUID(); diff --git a/src/core/notebook.h b/src/core/notebook.h index 12cbb1f..4e4d251 100644 --- a/src/core/notebook.h +++ b/src/core/notebook.h @@ -56,7 +56,7 @@ struct NotebookRecord { class Notebook { public: - virtual ~Notebook() = default; + virtual ~Notebook(); const std::string &GetId() const { return config_.id; } const std::string &GetRootFolder() const { return root_folder_; } diff --git a/src/platform/process_utils.cpp b/src/platform/process_utils.cpp index a68223a..cbc7ac3 100644 --- a/src/platform/process_utils.cpp +++ b/src/platform/process_utils.cpp @@ -16,7 +16,6 @@ FILE *ProcessUtils::OpenPipe(const std::string &command, const char *mode) { #ifdef _WIN32 return _popen(command.c_str(), mode); #else - (void)utf8_mode; return popen(command.c_str(), mode); #endif }