From 61f5ed79acf961864b0ad44c196701a4f0e10e56 Mon Sep 17 00:00:00 2001 From: subodhisawake Date: Tue, 5 May 2026 02:21:28 -0400 Subject: [PATCH] fix: remove stale @ts-ignore for localIdeographFontFamily across all map modules --- modules/main/src/mapbox-legacy/mapbox/mapbox.ts | 2 +- modules/react-mapbox/src/mapbox/mapbox.ts | 2 +- modules/react-maplibre/src/maplibre/maplibre.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/main/src/mapbox-legacy/mapbox/mapbox.ts b/modules/main/src/mapbox-legacy/mapbox/mapbox.ts index 5e3f295dd..362973cb5 100644 --- a/modules/main/src/mapbox-legacy/mapbox/mapbox.ts +++ b/modules/main/src/mapbox-legacy/mapbox/mapbox.ts @@ -501,7 +501,7 @@ export default class Mapbox { diff: styleDiffing }; if ('localIdeographFontFamily' in nextProps) { - // @ts-ignore Mapbox specific prop + // mapbox-gl v1 ships no bundled types but supports this option at runtime; TS 4.9+ in-narrowing makes this type-safe options.localIdeographFontFamily = nextProps.localIdeographFontFamily; } this._map.setStyle(normalizeStyle(mapStyle), options); diff --git a/modules/react-mapbox/src/mapbox/mapbox.ts b/modules/react-mapbox/src/mapbox/mapbox.ts index bb40fd7c3..39c20f9c9 100644 --- a/modules/react-mapbox/src/mapbox/mapbox.ts +++ b/modules/react-mapbox/src/mapbox/mapbox.ts @@ -498,7 +498,7 @@ export default class Mapbox { diff: styleDiffing }; if ('localIdeographFontFamily' in nextProps) { - // @ts-ignore Mapbox specific prop + // localIdeographFontFamily is a MapOptions field in mapbox-gl v3; TS 4.9+ in-narrowing makes this type-safe options.localIdeographFontFamily = nextProps.localIdeographFontFamily; } this._map.setStyle(normalizeStyle(mapStyle), options); diff --git a/modules/react-maplibre/src/maplibre/maplibre.ts b/modules/react-maplibre/src/maplibre/maplibre.ts index fa16e53ad..2b5bce996 100644 --- a/modules/react-maplibre/src/maplibre/maplibre.ts +++ b/modules/react-maplibre/src/maplibre/maplibre.ts @@ -446,7 +446,7 @@ export default class Maplibre { diff: styleDiffing }; if ('localIdeographFontFamily' in nextProps) { - // @ts-ignore Mapbox specific prop + // localIdeographFontFamily is a MapLibre StyleOptions field; TS 4.9+ in-narrowing makes this type-safe options.localIdeographFontFamily = nextProps.localIdeographFontFamily; } this._map.setStyle(normalizeStyle(mapStyle), options);