From 743e717970796dce4d6a60249255f835c3773ebd Mon Sep 17 00:00:00 2001 From: Rex Lorenzo Date: Fri, 24 Apr 2026 01:00:41 -0700 Subject: [PATCH 01/14] refactor(emergency-contact): extract shared page shell Hoist breadcrumb, loading spinner, and not-found banner from EmergencyContactForm.vue and EmergencyContactView.vue into a new EmergencyContactPageShell.vue. Each page now owns only its h1 and body content. Pure template refactor; no runtime change. --- .../components/EmergencyContactPageShell.vue | 39 +++++++++++++++++++ .../pages/EmergencyContactForm.vue | 33 ++++------------ .../pages/EmergencyContactView.vue | 34 ++++------------ 3 files changed, 53 insertions(+), 53 deletions(-) create mode 100644 VueApp/src/Students/EmergencyContact/components/EmergencyContactPageShell.vue diff --git a/VueApp/src/Students/EmergencyContact/components/EmergencyContactPageShell.vue b/VueApp/src/Students/EmergencyContact/components/EmergencyContactPageShell.vue new file mode 100644 index 000000000..ca0002d44 --- /dev/null +++ b/VueApp/src/Students/EmergencyContact/components/EmergencyContactPageShell.vue @@ -0,0 +1,39 @@ + + + diff --git a/VueApp/src/Students/EmergencyContact/pages/EmergencyContactForm.vue b/VueApp/src/Students/EmergencyContact/pages/EmergencyContactForm.vue index 1e0c56411..64bf4096a 100644 --- a/VueApp/src/Students/EmergencyContact/pages/EmergencyContactForm.vue +++ b/VueApp/src/Students/EmergencyContact/pages/EmergencyContactForm.vue @@ -5,6 +5,7 @@ import { useQuasar } from "quasar" import StatusBanner from "@/components/StatusBanner.vue" import StatusBadge from "@/components/StatusBadge.vue" import ContactSection from "../components/ContactSection.vue" +import EmergencyContactPageShell from "../components/EmergencyContactPageShell.vue" import PhoneInput from "../components/PhoneInput.vue" import { useEmergencyContact } from "../composables/use-emergency-contact" import { emergencyContactService } from "../services/emergency-contact-service" @@ -226,24 +227,11 @@ onBeforeRouteLeave(() => { -
+
- +
-
+
- +
-
+
These assignments will not be rolled forward because someone manually edited or deleted a percent assignment of the same type for this instructor after the term was harvested. diff --git a/VueApp/src/Effort/pages/TermManagement.vue b/VueApp/src/Effort/pages/TermManagement.vue index 2f3fdcac5..f968599b9 100644 --- a/VueApp/src/Effort/pages/TermManagement.vue +++ b/VueApp/src/Effort/pages/TermManagement.vue @@ -66,6 +66,7 @@ label="Boundary Year" dense outlined + hide-bottom-space style="max-width: 150px" :rules="[yearRule]" /> @@ -90,12 +91,14 @@ @click="openRolloverDialog" />
-
Changing the year from the default is unusual. Only do this if you need to run a past rollover. -
+
@@ -580,6 +583,7 @@ import { useDateFunctions } from "@/composables/DateFunctions" import HarvestDialog from "../components/HarvestDialog.vue" import PercentRolloverDialog from "../components/PercentRolloverDialog.vue" import ClinicalImportDialog from "../components/ClinicalImportDialog.vue" +import StatusBanner from "@/components/StatusBanner.vue" import type { TermDto, AvailableTermDto } from "../types" import type { QTableColumn } from "quasar"