Skip to content

Keep net-label connections out of physical routing#388

Open
ar-amk wants to merge 1 commit into
tscircuit:mainfrom
ar-amk:codex/tscircuit-79-net-label-routing
Open

Keep net-label connections out of physical routing#388
ar-amk wants to merge 1 commit into
tscircuit:mainfrom
ar-amk:codex/tscircuit-79-net-label-routing

Conversation

@ar-amk
Copy link
Copy Markdown

@ar-amk ar-amk commented May 20, 2026

/claim #79

Summary

  • clone the direct connectivity map before adding netConnections, so global label connectivity cannot mutate the direct routing map
  • queue MSP and long-distance routing candidates from direct physical connections only, while preserving the global connectivity map for label placement
  • add regression coverage for pure net-label-only nets and mixed direct+net-label nets in both routing stages
  • refresh visual snapshots so netConnections are represented as labels instead of routed traces

Tests

  • bun test tests/solvers/MspConnectionPairSolver/MspConnectionPairSolver_netConnections.test.ts tests/solvers/LongDistancePairSolver/LongDistancePairSolver_netConnections.test.ts
  • bun test
  • bun run format:check
  • bun run build
  • git diff --check

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
schematic-trace-solver Ready Ready Preview, Comment May 20, 2026 10:16pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant