fix: reconcile Zod 4 migration with current schemas

Author: carderne

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.alerts.new/route.tsx

@@ -277,7 +277,7 @@ export default function Page() {
     if (lastSubmission !== undefined) return;
 
     form.reset();
-  }, [navigation.state, lastSubmission]);
+  }, [navigation.state, lastSubmission, form]);
 
   return (
     <Dialog

apps/webapp/app/routes/api.v1.deployments.$deploymentId.build-env-vars.ts

@@ -87,7 +87,7 @@ export async function loader({ request, params }: LoaderFunctionArgs) {
     }
 
     const decrypted = await decryptSecret(env.ENCRYPTION_KEY, envelope.data);
-    const variables = z.record(z.string()).parse(JSON.parse(decrypted));
+    const variables = z.record(z.string(), z.string()).parse(JSON.parse(decrypted));
 
     return json({ variables } satisfies GetDeploymentBuildEnvVarsResponseBody, { status: 200 });
   } catch (error) {

apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.schedules.new/route.tsx

@@ -228,7 +228,7 @@ export function UpsertScheduleForm({
     const result = ScheduleWindow.safeParse(scheduleWindowValue);
     scheduleWindowResult = result.success
       ? { isValid: true }
-      : { isValid: false, error: result.error.errors[0].message };
+      : { isValid: false, error: result.error.issues[0].message };
   }
 
   if (cronPattern !== "") {
@@ -237,7 +237,7 @@ export function UpsertScheduleForm({
     if (!result.success) {
       cronPatternResult = {
         isValid: false,
-        error: result.error.errors[0].message,
+        error: result.error.issues[0].message,
       };
     } else {
       try {

apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.webhooks.endpoints.$endpointParam.send.ts

@@ -23,7 +23,7 @@ const SigningSecretSchema = z.object({ secret: z.string() });
 
 const SendSchema = z.object({
   body: z.string(),
-  headers: z.record(z.string()).optional(),
+  headers: z.record(z.string(), z.string()).optional(),
   signatureMode: z.enum(["signed", "unsigned", "tampered", "simulate"]).default("signed"),
   redirect: z.boolean().default(true),
 });

apps/webapp/app/v3/alertsWorker.server.ts

@@ -29,7 +29,7 @@ const DashboardAgentWatchAlertPayload = z.object({
   kind: z.string(),
   note: z.string(),
   firedAt: z.string(),
-  facts: z.record(z.unknown()),
+  facts: z.record(z.string(), z.unknown()),
   // Optional so a job enqueued before this deploy still validates and delivers.
   resolution: watchResolutionSchema.optional().catch(undefined),
   // `.catch` so an unrecognized observation shape degrades instead of dropping the alert.

apps/webapp/test/helpers/apiRunListPresenterTestHelpers.ts

@@ -157,6 +157,8 @@ export async function insertTaskRunV2Rows(clickhouse: ClickHouse, runs: TaskRun[
     task_version: run.taskVersion ?? "",
     sdk_version: run.sdkVersion ?? "",
     cli_version: run.cliVersion ?? "",
+    output: null,
+    error: null,
     machine_preset: run.machinePreset ?? "",
     root_run_id: "",
     parent_run_id: "",

internal-packages/dashboard-agent-contracts/src/blocks.ts

@@ -256,7 +256,7 @@ export const reportMetricSchema = z
       })
       .passthrough()
       .optional(),
-    breakdown: z.record(z.number()).optional(),
+    breakdown: z.record(z.string(), z.number()).optional(),
     annotation: z
       .object({ code: reasonCodeSchema, value: z.number().optional() })
       .passthrough()
@@ -272,7 +272,7 @@ export const reportRecommendationSchema = z
   .passthrough();
 
 const codeWithEvidenceSchema = z
-  .object({ code: reasonCodeSchema, evidence: z.record(z.number()).optional() })
+  .object({ code: reasonCodeSchema, evidence: z.record(z.string(), z.number()).optional() })
   .passthrough();
 
 export const reportFindingSchema = z
@@ -337,7 +337,7 @@ export const reportViewModelSchema = z
     findings: z.array(reportFindingSchema).default([]),
     metrics: z.array(reportMetricSchema).default([]),
     /** Free-form. The card reads only `trustworthy`. */
-    facts: z.record(z.unknown()).default({}),
+    facts: z.record(z.string(), z.unknown()).default({}),
     links: z.array(reportLinkSchema).default([]),
     footer: z.array(reportFooterEntrySchema).default([]),
   })

internal-packages/dashboard-agent/src/watch-actions.ts

@@ -96,11 +96,11 @@ export const watchWakeActionSchema = z.object({
       checkEveryMinutes: z.number().optional(),
     })
     .passthrough(),
-  facts: z.record(z.unknown()).default({}),
+  facts: z.record(z.string(), z.unknown()).default({}),
   // Optional for the same reason: an older watcher predating the resolution model
   // sends neither, and the narration falls back to the transport encoding.
   resolution: z.enum(watchResolutions).optional(),
-  observed: z.record(z.unknown()).optional(),
+  observed: z.record(z.string(), z.unknown()).optional(),
   note: z.string().optional(),
   investigateOnAttention: z.boolean().optional(),
 });
@@ -147,9 +147,9 @@ export const watchInvestigateActionSchema = z.object({
       checkEveryMinutes: z.number().optional(),
     })
     .passthrough(),
-  facts: z.record(z.unknown()).default({}),
+  facts: z.record(z.string(), z.unknown()).default({}),
   resolution: z.enum(watchResolutions).optional(),
-  observed: z.record(z.unknown()).optional(),
+  observed: z.record(z.string(), z.unknown()).optional(),
   note: z.string().optional(),
   investigationId: z.string().optional(),
 });

internal-packages/webhook-sources/src/sampleRecord.ts

@@ -26,7 +26,7 @@ export const SampleRecord = z.object({
   name: z.string(),
   description: z.string().optional(),
   body: z.unknown(),
-  extraHeaders: z.record(z.string()).optional(),
+  extraHeaders: z.record(z.string(), z.string()).optional(),
   docsUrl: z.string().optional(),
   provenance: SampleProvenance,
 });

packages/cli-v3/src/entryPoints/managed/snapshot.test.ts

@@ -368,7 +368,6 @@ describe("SnapshotManager", () => {
     const executionOrder: string[] = [];
     const executionTimes: { start: number; end: number; type: string }[] = [];
     let currentlyExecuting = false;
-    let _handlerExecutionCount = 0;
 
     const manager = new SnapshotManager({
       runnerId: "test-runner-1",
@@ -381,7 +380,6 @@ describe("SnapshotManager", () => {
           throw new Error("Handler executed while another handler was running");
         }
         currentlyExecuting = true;
-        handlerExecutionCount++;
 
         const start = Date.now();
         executionOrder.push(`snapshot:${data.snapshot.friendlyId}`);
@@ -396,7 +394,6 @@ describe("SnapshotManager", () => {
           throw new Error("Handler executed while another handler was running");
         }
         currentlyExecuting = true;
-        handlerExecutionCount++;
 
         const start = Date.now();
         executionOrder.push(`suspendable:${state.id}`);