Fix automated release process: Updates GHA types and build dependencies (#1675)

* Fix release automation: use environment variables for auth and repo

* Improve release script: fail hard on error and print details

* Update deprecated GitHub Actions to v4

* Upgrade fontmake and glyphsLib to support newer Glyphs format

* Replace container with ubuntu-latest and explicit dependencies (Python 3.12, sfnt2woff-zopfli)

Author: hunterhogan

.github/workflows/build.yml

@@ -11,17 +11,42 @@ on:
 
 jobs:
   build:
+    permissions:
+      contents: write
     runs-on: ubuntu-latest
-    container: tonsky/firacode:latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
+    - name: Set up Python 3.12
+      uses: actions/setup-python@v5
+      with:
+        python-version: '3.12'
+    - name: Install System Dependencies
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y ttfautohint woff2 zlib1g-dev
+    - name: Install sfnt2woff-zopfli
+      run: |
+        git clone https://github.com/bramstein/sfnt2woff-zopfli.git
+        cd sfnt2woff-zopfli
+        make
+        chmod +x sfnt2woff-zopfli
+        sudo mv sfnt2woff-zopfli /usr/local/bin/sfnt2woff-zopfli
+        cd ..
+        rm -rf sfnt2woff-zopfli
+    - name: Install Python Dependencies
+      run: |
+        pip install --upgrade pip
+        pip install fontmake glyphsLib gftools fontbakery ufo2ft statmake
     - if: startsWith(github.ref, 'refs/tags/')
       run: python3 ./script/update_version.py
     - run: ./script/build.sh
     - run: echo "hash=$(git rev-parse --short $GITHUB_SHA)" >> $GITHUB_ENV
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: Fira_Code_${{ env.hash }}
         path: distr
     - if: startsWith(github.ref, 'refs/tags/')
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        GITHUB_REPOSITORY: ${{ github.repository }}
       run: python3 ./script/release.py

script/release.py

@@ -1,5 +1,5 @@
 #! /usr/bin/env python3
-import argparse, base64, common, glob, os, platform, re, subprocess, sys, urllib.request, zipfile
+import argparse, base64, common, glob, json, os, platform, re, subprocess, sys, urllib.request, urllib.error, zipfile
 
 def log_errors(name):
   def wrap(f):
@@ -25,26 +25,38 @@ def github_headers():
   if os.environ.get('GITHUB_BASIC'):
     auth = 'Basic ' + base64.b64encode(os.environ.get('GITHUB_BASIC').encode('utf-8')).decode('utf-8')
   else:
-    auth = 'token ' + os.environ.get('API_TOKEN')
+    token = os.environ.get('API_TOKEN') or os.environ.get('GITHUB_TOKEN')
+    if not token:
+      raise Exception("Missing API_TOKEN or GITHUB_TOKEN")
+    auth = 'token ' + token
   return {
     'Accept': 'application/vnd.github.v3+json',
     'Authorization': auth
   }
 
-@log_errors("github_release")
 def github_release(version):
   zip = f"Fira_Code_v{version}.zip"
 
+  repo = os.environ.get('GITHUB_REPOSITORY', 'tonsky/FiraCode')
+  print(f"Releasing to {repo}")
+
   data = '{"tag_name":"' + version + '","name":"' + version + '"}'
   headers = github_headers()
-  resp = urllib.request.urlopen(urllib.request.Request('https://api.github.com/repos/tonsky/FiraCode/releases', data=data.encode('utf-8'), headers=headers)).read()
-  upload_url = re.match('https://.*/assets', json.loads(resp.decode('utf-8'))['upload_url']).group(0)
+  
+  try:
+    req = urllib.request.Request(f'https://api.github.com/repos/{repo}/releases', data=data.encode('utf-8'), headers=headers)
+    resp = urllib.request.urlopen(req).read()
+    upload_url = re.match('https://.*/assets', json.loads(resp.decode('utf-8'))['upload_url']).group(0)
 
-  print('github_release: Uploading', zip, 'to', upload_url)
-  headers['Content-Type'] = 'application/zip'
-  headers['Content-Length'] = os.path.getsize(zip)
-  with open(zip, 'rb') as data:
-    urllib.request.urlopen(urllib.request.Request(upload_url + '?name=' + zip, data=data, headers=headers))
+    print('github_release: Uploading', zip, 'to', upload_url)
+    headers['Content-Type'] = 'application/zip'
+    headers['Content-Length'] = os.path.getsize(zip)
+    with open(zip, 'rb') as data:
+      urllib.request.urlopen(urllib.request.Request(upload_url + '?name=' + zip, data=data, headers=headers))
+  except urllib.error.HTTPError as e:
+    print(f"github_release: HTTP Error {e.code} {e.reason}")
+    print(e.read().decode('utf-8'))
+    raise e
 
 @log_errors("npm_publish")
 def npm_publish(version):