-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Context
- Follow-up from PR Sepolia happy-path: th verify (Etherscan+Sourcify) + chain-config recording #5 (th verify improvements).
Problem
th verifyrunsforge verify-contractviaspawnSyncand captures stdout/stderr.- Node’s default
spawnSyncstdout/stderr buffer can be exceeded in edge cases, causing verification to fail even if forge would otherwise succeed.
Proposal
- Set an explicit
maxBufferwhen invokingspawnSync('forge', ...)(e.g. 10–20MB). - Consider adding a lightweight guardrail: if output is truncated/overflowed, persist a message into
manifest.extensions.verification[chainId]indicating output was truncated.
Acceptance criteria
th verifydoes not fail due to buffer overflow for large forge output.- Verification results are still written to
manifest.extensions.verification[chainId]with actionable error context.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels