Fix pagination#378
Open
Yostra wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stripe's List API can return an empty page when
starting_after(orending_before) points at an object whosecreatedsecond is fully inside thecreated[gte]/lt]window. The cursor effectively "loses" the rest of that one-second bucket, so any subdivision branch that inherited the cursor would silently skip records.This PR removes the assumption that a cursor can drain a same-second boundary and instead re-queries that second by timestamp.
What changed
subdivideRanges: child ranges no longer inherit the parent cursor. Every child is fetched fresh from itscreatedbounds. The final (newest) child is still widened tolastObserved + 1sso the boundary second is covered without relying on the cursor.< 30sto<= 1sso we only fall back to cursor-only pagination when there is genuinely nothing left to split.streamingSubdivide: yields a shallow clone ofrangeand forwardslastObservedon the event, so downstreamrange_completeaccounting uses the fetch result instead of re-scanning emitted records.fetchPageForRange: treatsdateas the created-timestamp fallback (invoice items usedate, notcreated), and the head-completion logic initerateStreammatches.concurrency: 100forstreamingSubdivide.