You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 1f54aa1
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: .github/actions/update-project-versions/README.md
+23-1Lines changed: 23 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -10,12 +10,34 @@ The action walks the `directory` input (default: repo root) recursively and upda
10
10
|---|---|
11
11
|`pom.xml` (root) |`<version>` of the project itself |
12
12
|`pom.xml` (all) |`<parent><version>` when the parent belongs to this project or is tracked in `versions`|
13
-
|`pom.xml` (root **and** child modules) |`<properties>` entries whose key ends in `.version` when the project name is in `versions`|
13
+
|`pom.xml` (root **and** child modules) |`<properties>` entries whose key ends in `.version` when the project name is in `versions`, unless [pinned](#pinning-a-property-with-releaserversion-check-off)|
14
14
|`gradle.properties`| Bare `version=` key → `project-version`; `{prefix}Version=` keys → looked up in `versions` via camelCase→kebab-case conversion |
Here `spring-cloud-function.version` is bumped as usual and `spring-cloud-stream.version` is not.
29
+
30
+
**This exists for dependency cycles inside a release train.**`spring-cloud-stream` builds against `spring-cloud-function`, and `spring-cloud-function`'s samples build against `spring-cloud-stream`. Pointing both at the other's snapshot is a cycle, so one side pins to a released version and says so in the pom.
31
+
32
+
The marker is matched against the property it trails, not the file, so a pinned entry does not pin its neighbours. A pinned property is **reported in the log even though nothing changed** — a property deliberately left alone otherwise looks exactly like the bump quietly missing one:
33
+
34
+
```
35
+
Left alone in spring-cloud-function-samples/function-sample-cloudevent-stream/pom.xml
36
+
(@releaser:version-check-off): spring-cloud-stream.version (pinned at 4.3.4)
37
+
```
38
+
39
+
It applies to `<properties>` entries only. A project's own `<version>` is not covered — an unreleasable project is expressed by leaving it out of the release train, not by a marker.
Copy file name to clipboardExpand all lines: .github/workflows/README-post-release.md
+2Lines changed: 2 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -264,6 +264,8 @@ If all three attempts fail, the step **records a status and exits 0** rather tha
264
264
265
265
The `ls-remote` is checked the same way for a related reason. `--exit-code` exits **2** when the remote answered and has no such branch — a real answer, and the common one — while any other non-zero is a transport failure. Treating the two alike would skip the merge for a project whose release branch was there all along, bump it anyway, and call the run a success.
266
266
267
+
**`already-merged` alongside `would-push` is not a contradiction.** The Merge column answers "did `release/<version>` need merging into `.x`", and the Push column answers "is there anything to push at all" — and the version bump is a commit in its own right. Most runs show exactly that pair, because the merge has usually happened already while the snapshot bump has not. `nothing-to-push` means the branch was already at the new versions too. The summary says so under the table.
268
+
267
269
The merge commit and the version-bump commit go up in a **single push**: one CI run per project, and if anything fails in between, nothing is pushed and the branch is left untouched so the whole project can simply be re-run. The `release/<version>` branch is left in place, not deleted.
268
270
269
271
### CI and PR workflow files are preserved across the merge
0 commit comments