fix(enrichment): keep cascade detail sticky on upsert; mark unattempted providers not_run on abort

Author: TheodoreSpeaks

apps/sim/enrichments/run.test.ts

@@ -125,6 +125,21 @@ describe('runEnrichment cascade detail', () => {
     expect(mockExecuteTool).not.toHaveBeenCalled()
   })
 
+  it('marks unattempted providers not_run when the signal is already aborted', async () => {
+    const controller = new AbortController()
+    controller.abort()
+    const outcome = await runEnrichment(
+      config([prov('a'), prov('b')]),
+      {},
+      {
+        ...ctx,
+        signal: controller.signal,
+      }
+    )
+    expect(mockExecuteTool).not.toHaveBeenCalled()
+    expect(outcome.detail.providers.map((p) => p.status)).toEqual(['not_run', 'not_run'])
+  })
+
   it('does not error when some providers no-match and only some error', async () => {
     mockExecuteTool.mockImplementation((toolId: string) => {
       if (toolId === 'tool_a') return { success: false, output: { status: 500 } }

apps/sim/enrichments/run.ts

@@ -83,7 +83,6 @@ export async function runEnrichment(
   let errorCount = 0
   let lastError: string | null = null
   let matchedProvider: string | null = null
-  let matchedIndex = -1
   let winner: { result: Record<string, unknown>; label: string } | null = null
   const providers: EnrichmentProviderOutcome[] = []
   const startedAt = Date.now()
@@ -147,7 +146,6 @@ export async function runEnrichment(
           error: null,
         })
         matchedProvider = provider.id
-        matchedIndex = i
         winner = { result, label: provider.label }
         logger.info('Enrichment hit', { enrichmentId: enrichment.id, provider: provider.id })
         break
@@ -182,21 +180,21 @@ export async function runEnrichment(
     }
   }
 
-  // The cascade short-circuits on a match — record the providers it never
-  // reached so the panel shows the full configured cascade.
-  if (matchedIndex >= 0) {
-    for (let i = matchedIndex + 1; i < enrichment.providers.length; i++) {
-      const provider = enrichment.providers[i]
-      providers.push({
-        id: provider.id,
-        label: provider.label,
-        toolId: provider.toolId,
-        status: 'not_run',
-        cost: 0,
-        durationMs: 0,
-        error: null,
-      })
-    }
+  // Any provider not represented yet never ran — the cascade short-circuited on
+  // a match or aborted mid-run. Record them as `not_run` (in registry order) so
+  // the panel always shows the full configured cascade.
+  const seen = new Set(providers.map((p) => p.id))
+  for (const provider of enrichment.providers) {
+    if (seen.has(provider.id)) continue
+    providers.push({
+      id: provider.id,
+      label: provider.label,
+      toolId: provider.toolId,
+      status: 'not_run',
+      cost: 0,
+      durationMs: 0,
+      error: null,
+    })
   }
 
   const completedAt = Date.now()

apps/sim/lib/table/rows/executions.ts

@@ -276,7 +276,11 @@ export async function writeExecutionsPatch(
             runningBlockIds: insertValues.runningBlockIds,
             blockErrors: insertValues.blockErrors,
             cancelledAt: insertValues.cancelledAt,
-            enrichmentDetails: insertValues.enrichmentDetails,
+            // Sticky: preserve a prior cascade breakdown when this write omits
+            // it (e.g. the running pickup stamp) so only an explicit detail
+            // overwrites it. Re-runs delete the row first, so this never serves
+            // stale detail across runs.
+            enrichmentDetails: sql`coalesce(excluded.enrichment_details, ${tableRowExecutions.enrichmentDetails})`,
             updatedAt: insertValues.updatedAt,
           },
           where: and(
@@ -311,7 +315,10 @@ export async function writeExecutionsPatch(
           runningBlockIds: insertValues.runningBlockIds,
           blockErrors: insertValues.blockErrors,
           cancelledAt: insertValues.cancelledAt,
-          enrichmentDetails: insertValues.enrichmentDetails,
+          // Sticky: preserve a prior cascade breakdown when this write omits it
+          // (e.g. the running pickup stamp) so only an explicit detail overwrites
+          // it. Re-runs delete the row first, so this never serves stale detail.
+          enrichmentDetails: sql`coalesce(excluded.enrichment_details, ${tableRowExecutions.enrichmentDetails})`,
           updatedAt: insertValues.updatedAt,
         },
       })