Skip to content

Commit e592345

Browse files
committed
ci: run the mobile browsers one after the other again
1 parent f3ec391 commit e592345

2 files changed

Lines changed: 6 additions & 23 deletions

File tree

‎.github/scripts/http-e2e.sh‎

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -201,27 +201,11 @@ case "$group" in
201201
export NODE_OPTIONS="${NODE_OPTIONS:+$NODE_OPTIONS }--max-old-space-size=12288"
202202
bunx --no-install playwright install --with-deps chromium webkit
203203
start_app mobile 3024 'mobile browser' record-http-status
204-
# Chromium and WebKit run as two processes against the one app, so WebKit no longer waits out
205-
# Chromium's pass. Each process seeds and removes its own fixtures under fresh ids and writes
206-
# its own report, so they share nothing but the server.
207-
browser_pids=()
208-
for browser in chromium webkit; do
209-
MOBILE_E2E_BROWSER="$browser" \
210-
MOBILE_E2E_BASE_URL="$NEXT_PUBLIC_APP_URL" \
211-
MOBILE_E2E_DATABASE_URL="$DATABASE_URL" \
212-
MOBILE_E2E_AUTH_SECRET="$BETTER_AUTH_SECRET" \
213-
MOBILE_E2E_REPORT_PATH="$report_dir/mobile-e2e-$browser-report.json" \
214-
bun run test:mobile:e2e > "$report_dir/mobile-$browser.log" 2>&1 &
215-
browser_pids+=("$!")
216-
done
217-
browsers_failed=0
218-
for pid in "${browser_pids[@]}"; do wait "$pid" || browsers_failed=1; done
219-
for browser in chromium webkit; do
220-
echo "::group::Mobile checks: $browser"
221-
cat "$report_dir/mobile-$browser.log"
222-
echo "::endgroup::"
223-
done
224-
[ "$browsers_failed" = 0 ]
204+
MOBILE_E2E_BASE_URL="$NEXT_PUBLIC_APP_URL" \
205+
MOBILE_E2E_DATABASE_URL="$DATABASE_URL" \
206+
MOBILE_E2E_AUTH_SECRET="$BETTER_AUTH_SECRET" \
207+
MOBILE_E2E_REPORT_PATH="$report_dir/mobile-e2e-report.json" \
208+
bun run test:mobile:e2e
225209
;;
226210

227211
*)

‎apps/sim/scripts/test-mobile-e2e.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ import postgres from 'postgres'
2020
* Real browser coverage against a running local app and disposable PostgreSQL.
2121
* Requires MOBILE_E2E_BASE_URL, MOBILE_E2E_DATABASE_URL, MOBILE_E2E_AUTH_SECRET,
2222
* and MOBILE_E2E_REPORT_PATH. Install Chromium and WebKit with Playwright first.
23-
* MOBILE_E2E_BROWSER runs one browser (CI runs one process per browser, against one app), and
24-
* MOBILE_E2E_VIEWPORT narrows a diagnostic rerun.
23+
* MOBILE_E2E_BROWSER and MOBILE_E2E_VIEWPORT narrow a diagnostic rerun.
2524
*/
2625
const logger = createLogger('MobileE2E')
2726
const expect = browserExpect.configure({ timeout: 20_000 })

0 commit comments

Comments
 (0)