fix(tables): address review — id-key exec clears + waiting labels, name in upsert error, un-gate group output ids

Author: TheodoreSpeaks

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/data-row.tsx

@@ -181,17 +181,22 @@ export const DataRow = React.memo(function DataRow({
    */
   const waitingByGroupId = React.useMemo(() => {
     if (workflowGroups.length === 0) return null
+    // Deps are stored as column ids; the "Waiting on …" pill shows display names.
+    const nameByColumnId = new Map(columns.map((c) => [c.key, c.name]))
     const map = new Map<string, string[]>()
     for (const group of workflowGroups) {
       // autoRun=false groups never fire from the scheduler — there's nothing
       // to wait on. The cell stays empty until the user clicks Run manually.
       if (group.autoRun === false) continue
       const unmet = getUnmetGroupDeps(group, row)
       if (unmet.columns.length === 0) continue
-      map.set(group.id, unmet.columns)
+      map.set(
+        group.id,
+        unmet.columns.map((id) => nameByColumnId.get(id) ?? id)
+      )
     }
     return map
-  }, [workflowGroups, row])
+  }, [workflowGroups, row, columns])
   const isMultiCell = sel !== null && (sel.startRow !== sel.endRow || sel.startCol !== sel.endCol)
   const isRowSelected = isRowChecked
   /**

apps/sim/lib/table/service.ts

@@ -2232,7 +2232,10 @@ export async function upsertRow(
   // the persisted type (e.g. a coerced `"123"` → `123` matches existing rows).
   const targetValue = data.data[targetColumnKey]
   if (targetValue === undefined || targetValue === null) {
-    throw new Error(`Upsert requires a value for the conflict target column "${targetColumnKey}"`)
+    // Surface the display name, not the internal id — v1 callers pass a name.
+    const targetColumnName =
+      uniqueColumns.find((c) => getColumnId(c) === targetColumnKey)?.name ?? targetColumnKey
+    throw new Error(`Upsert requires a value for the conflict target column "${targetColumnName}"`)
   }
 
   // `data->` and `data->>` accept the JSON key as a parameterized text value;
@@ -2577,10 +2580,10 @@ function deriveExecClearsForDataPatch(
   // that group's exec entry so the auto-fire reactor re-arms the cell.
   // Also flags the cleared output column as dirty so transitive downstream
   // groups see it.
-  for (const [columnName, value] of Object.entries(dataPatch)) {
+  for (const [columnId, value] of Object.entries(dataPatch)) {
     const cleared = value === null || value === undefined || value === ''
     if (!cleared) continue
-    const col = schema.columns.find((c) => c.name === columnName)
+    const col = schema.columns.find((c) => getColumnId(c) === columnId)
     if (col?.workflowGroupId) groupsToClear.add(col.workflowGroupId)
   }
 
@@ -3923,12 +3926,12 @@ export async function addWorkflowGroup(
       )
     }
 
-    // Assign stable ids to the new output columns (flag on), then rewrite the
-    // group's column refs from name → id so outputs/deps/inputMappings key on
-    // ids — matching the row-data storage key and surviving future renames.
+    // Assign stable ids to the new output columns, then rewrite the group's
+    // column refs from name → id so outputs/deps/inputMappings key on ids —
+    // matching the row-data storage key and surviving future renames.
     const takenIds = new Set(collectColumnIds(schema))
     const outputColumns = data.outputColumns.map((col) => {
-      if (col.id || !isTablesFractionalOrderingEnabled) return col
+      if (col.id) return col
       const id = generateColumnId(takenIds)
       takenIds.add(id)
       return { ...col, id }