test(billing): latest-sync helper fails loudly on an enqueue-time tie

Author: waleedlatif1

apps/sim/lib/billing/webhooks/stripe-sync-convergence.integration.ts

@@ -255,23 +255,29 @@ async function leaveOrganization(userId: string, organizationId: string) {
     .where(and(eq(member.userId, userId), eq(member.organizationId, organizationId)))
 }
 
+/**
+ * The sync event enqueued last for a subscription. `created_at` is the enqueuing transaction's
+ * start time, compared at microsecond precision, so it orders events from different
+ * transactions. No test enqueues two of one type for one subscription in a single transaction,
+ * and a tie fails loudly rather than being broken arbitrarily: `outbox_event` has no per-insert
+ * sequence to break it with.
+ */
 async function latestOutboxEventId(eventType: string, subscriptionId: string) {
-  const [latest] = await testDatabase
-    .select({ id: outboxEvent.id })
+  const [latest, previous] = await testDatabase
+    .select({ id: outboxEvent.id, createdAt: sql<string>`${outboxEvent.createdAt}::text` })
     .from(outboxEvent)
     .where(
       and(
         eq(outboxEvent.eventType, eventType),
         sql`${outboxEvent.payload} ->> 'subscriptionId' = ${subscriptionId}`
       )
     )
-    .orderBy(
-      desc(outboxEvent.createdAt),
-      sql`(${outboxEvent.payload} ->> 'committedAt')::numeric desc nulls last`,
-      desc(outboxEvent.id)
-    )
-    .limit(1)
+    .orderBy(desc(outboxEvent.createdAt))
+    .limit(2)
   if (!latest) throw new Error(`No ${eventType} event for ${subscriptionId}`)
+  if (previous?.createdAt === latest.createdAt) {
+    throw new Error(`Two ${eventType} events for ${subscriptionId} share one enqueue time`)
+  }
   return latest.id
 }