refactor use chat

Author: icecrasher321

.github/CODEOWNERS

@@ -24,5 +24,6 @@
 # Client-side stream consumption, hydration, and reconnect.
 /apps/sim/app/workspace/*/home/hooks/index.ts @simstudioai/mothership
 /apps/sim/app/workspace/*/home/hooks/use-chat.ts @simstudioai/mothership
-/apps/sim/app/workspace/*/home/hooks/use-file-preview-sessions.ts @simstudioai/mothership
+/apps/sim/app/workspace/*/home/hooks/preview/ @simstudioai/mothership
+/apps/sim/app/workspace/*/home/hooks/stream/ @simstudioai/mothership
 /apps/sim/hooks/queries/tasks.ts @simstudioai/mothership

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/docx-preview.tsx

@@ -5,10 +5,10 @@ import { createLogger } from '@sim/logger'
 import { toError } from '@sim/utils/errors'
 import { cn } from '@/lib/core/utils/cn'
 import type { WorkspaceFileRecord } from '@/lib/uploads/contexts/workspace'
-import { useWorkspaceFileBinary } from '@/hooks/queries/workspace-files'
 import { PDF_PAGE_SKELETON, PreviewError, resolvePreviewError } from './preview-shared'
 import { PreviewToolbar } from './preview-toolbar'
 import { bindPreviewWheelZoom } from './preview-wheel-zoom'
+import { useDocPreviewBinary } from './use-doc-preview-binary'
 
 const logger = createLogger('DocxPreview')
 
@@ -62,30 +62,15 @@ function fitDocxToContainer(host: HTMLElement, viewport: HTMLElement, zoomPercen
 export const DocxPreview = memo(function DocxPreview({
   file,
   workspaceId,
-  streamingContent,
 }: {
   file: WorkspaceFileRecord
   workspaceId: string
-  streamingContent?: string
 }) {
   const containerRef = useRef<HTMLDivElement>(null)
   const scrollContainerRef = useRef<HTMLDivElement>(null)
   const zoomPercentRef = useRef(100)
-  // Generated docs are 0 bytes until the tool commits the compiled source at the
-  // end of the run; only fetch the compiled artifact once content exists so we
-  // don't 409-poll the serve route throughout generation. Uploaded docs always
-  // have size > 0, so they fetch immediately as before.
-  const hasCommittedContent = (file.size ?? 0) > 0
-  const {
-    data: fileData,
-    isLoading,
-    error: fetchError,
-  } = useWorkspaceFileBinary(workspaceId, file.id, file.key, {
-    enabled: hasCommittedContent,
-    // edit_content updates in place (same storage key); version on updatedAt so an
-    // open preview refetches the new binary instead of showing the stale one.
-    version: Number(new Date(file.updatedAt)) || file.size,
-  })
+  const preview = useDocPreviewBinary(workspaceId, file)
+  const fileData = preview.data
   const [renderError, setRenderError] = useState<string | null>(null)
   const [rendering, setRendering] = useState(false)
   const [hasRenderedPreview, setHasRenderedPreview] = useState(false)
@@ -191,7 +176,7 @@ export const DocxPreview = memo(function DocxPreview({
   }, [pageCount, documentRenderVersion])
 
   useEffect(() => {
-    if (!containerRef.current || !fileData || streamingContent !== undefined) return
+    if (!containerRef.current || !fileData) return
 
     let cancelled = false
 
@@ -229,18 +214,12 @@ export const DocxPreview = memo(function DocxPreview({
     return () => {
       cancelled = true
     }
-  }, [fileData, streamingContent, applyPostRenderStyling])
+  }, [fileData, applyPostRenderStyling])
 
-  // The document is compiled to a committed binary (E2B doc sandbox, or
-  // isolated-vm when disabled) and rendered from the committed artifact above.
-  // There is no live per-tick preview: while the agent is still generating
-  // (streamingContent defined), the skeleton shows until the artifact lands.
-  const error = streamingContent !== undefined ? null : resolvePreviewError(fetchError, renderError)
+  const error = resolvePreviewError(preview.error, renderError)
   if (error) return <PreviewError label='document' error={error} />
 
-  const showSkeleton =
-    !hasRenderedPreview &&
-    (streamingContent !== undefined || isLoading || rendering || !hasCommittedContent)
+  const showSkeleton = !hasRenderedPreview && (!fileData || rendering)
 
   const scrollToPage = (page: number) => {
     const scrollContainer = scrollContainerRef.current

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/file-viewer.tsx

@@ -9,6 +9,7 @@ import { getFileExtension } from '@/lib/uploads/utils/file-utils'
 import { useWorkspaceFileBinary } from '@/hooks/queries/workspace-files'
 import { resolveFileCategory } from './file-category'
 import type { StreamingMode } from './text-editor-state'
+import { useDocPreviewBinary } from './use-doc-preview-binary'
 
 export type { StreamingMode } from './text-editor-state'
 
@@ -88,14 +89,7 @@ export function FileViewer({
   }
 
   if (category === 'iframe-previewable') {
-    return (
-      <IframePreview
-        key={file.id}
-        file={file}
-        workspaceId={workspaceId}
-        streamingContent={streamingContent}
-      />
-    )
+    return <IframePreview key={file.id} file={file} workspaceId={workspaceId} />
   }
 
   if (category === 'image-previewable') {
@@ -111,29 +105,15 @@ export function FileViewer({
   }
 
   if (category === 'docx-previewable') {
-    return (
-      <DocxPreview
-        key={file.id}
-        file={file}
-        workspaceId={workspaceId}
-        streamingContent={streamingContent}
-      />
-    )
+    return <DocxPreview key={file.id} file={file} workspaceId={workspaceId} />
   }
 
   if (category === 'pptx-previewable') {
-    return (
-      <PptxPreview
-        key={file.id}
-        file={file}
-        workspaceId={workspaceId}
-        streamingContent={streamingContent}
-      />
-    )
+    return <PptxPreview key={file.id} file={file} workspaceId={workspaceId} />
   }
 
   if (category === 'xlsx-previewable') {
-    return <XlsxPreview file={file} workspaceId={workspaceId} />
+    return <XlsxPreview key={file.id} file={file} workspaceId={workspaceId} />
   }
 
   return <UnsupportedPreview file={file} />
@@ -142,45 +122,30 @@ export function FileViewer({
 const IframePreview = memo(function IframePreview({
   file,
   workspaceId,
-  streamingContent,
 }: {
   file: WorkspaceFileRecord
   workspaceId: string
-  streamingContent?: string
 }) {
-  // Generated PDFs are 0 bytes until the tool commits the compiled source at the
-  // end of the run; only fetch the compiled artifact once content exists so we
-  // don't 409-poll the serve route throughout generation. Uploaded PDFs always
-  // have size > 0, so they fetch immediately as before. Re-fetches when the file
-  // record is invalidated, so the preview renders once the artifact lands.
-  const {
-    data: fileData,
-    isLoading,
-    error: fetchError,
-    dataUpdatedAt,
-  } = useWorkspaceFileBinary(workspaceId, file.id, file.key, {
-    enabled: (file.size ?? 0) > 0,
-    // edit_content updates in place (same storage key); version on updatedAt so an
-    // open preview refetches the new binary instead of showing the stale one.
-    version: Number(new Date(file.updatedAt)) || file.size,
-  })
+  const preview = useDocPreviewBinary(workspaceId, file)
 
   const bufferSource = useMemo<PdfDocumentSource | null>(
-    () => (fileData ? { kind: 'buffer', buffer: fileData } : null),
-    [fileData]
+    () => (preview.data ? { kind: 'buffer', buffer: preview.data } : null),
+    [preview.data]
   )
 
-  // No live per-tick preview: suppress transient fetch errors while generating
-  // (streamingContent defined) so the skeleton shows instead of a flash.
-  const error = streamingContent !== undefined ? null : resolvePreviewError(fetchError, null)
+  const error = resolvePreviewError(preview.error, null)
   if (error) return <PreviewError label='PDF' error={error} />
 
-  if (streamingContent !== undefined || isLoading || !bufferSource) {
+  if (!bufferSource) {
     return <div className='relative flex flex-1 overflow-hidden'>{PDF_PAGE_SKELETON}</div>
   }
 
   return (
-    <PdfViewerCore key={`${file.id}:${dataUpdatedAt}`} source={bufferSource} filename={file.name} />
+    <PdfViewerCore
+      key={`${file.id}:${preview.dataUpdatedAt}`}
+      source={bufferSource}
+      filename={file.name}
+    />
   )
 })
 

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/index.ts

@@ -1,3 +1,4 @@
+export { resolveFileCategory } from './file-category'
 export type { PreviewMode } from './file-viewer'
 export { FileViewer, isPreviewable, isTextEditable } from './file-viewer'
 export { RICH_PREVIEWABLE_EXTENSIONS } from './preview-panel'

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/pptx-preview.tsx

@@ -9,7 +9,7 @@ import {
   PreviewError,
   resolvePreviewError,
 } from '@/app/workspace/[workspaceId]/files/components/file-viewer/preview-shared'
-import { useWorkspaceFileBinary } from '@/hooks/queries/workspace-files'
+import { useDocPreviewBinary } from '@/app/workspace/[workspaceId]/files/components/file-viewer/use-doc-preview-binary'
 
 const logger = createLogger('PptxPreview')
 
@@ -44,36 +44,16 @@ function pptxCacheKey(fileId: string, dataUpdatedAt: number, byteLength: number)
 export const PptxPreview = memo(function PptxPreview({
   file,
   workspaceId,
-  streamingContent,
 }: {
   file: WorkspaceFileRecord
   workspaceId: string
-  streamingContent?: string
 }) {
-  // Generated decks are 0 bytes until the tool commits the compiled source at the
-  // end of the run; only fetch the compiled artifact once content exists so we
-  // don't 409-poll the serve route throughout generation. Uploaded decks always
-  // have size > 0, so they fetch immediately as before.
-  const {
-    data: fileData,
-    error: fetchError,
-    dataUpdatedAt,
-  } = useWorkspaceFileBinary(workspaceId, file.id, file.key, {
-    enabled: (file.size ?? 0) > 0,
-    // edit_content updates in place (same storage key); version on updatedAt so an
-    // open preview refetches the new binary instead of showing the stale one.
-    version: Number(new Date(file.updatedAt)) || file.size,
-  })
-
-  const cacheKey = pptxCacheKey(file.id, dataUpdatedAt, fileData?.byteLength ?? 0)
+  const preview = useDocPreviewBinary(workspaceId, file)
+  const fileData = preview.data
+  const cacheKey = pptxCacheKey(file.id, preview.dataUpdatedAt, fileData?.byteLength ?? 0)
 
   const [hasRendered, setHasRendered] = useState(false)
   const [renderError, setRenderError] = useState<string | null>(null)
-  // The deck is compiled to a committed binary (E2B doc sandbox, or isolated-vm
-  // when disabled) and served by useWorkspaceFileBinary. There is no live per-tick
-  // preview: while the agent is still generating (isStreaming), we show the
-  // loading skeleton and render the committed artifact once it lands/updates.
-  const isStreaming = streamingContent !== undefined
 
   useEffect(() => {
     setRenderError(null)
@@ -93,9 +73,7 @@ export const PptxPreview = memo(function PptxPreview({
     setRenderError(message || 'Failed to render presentation')
   }
 
-  // Suppress transient fetch errors while generating — show the skeleton instead
-  // of a "failed to preview" flash until the committed artifact is ready.
-  const error = isStreaming ? null : resolvePreviewError(fetchError, renderError)
+  const error = resolvePreviewError(preview.error, renderError)
 
   if (error) return <PreviewError label='presentation' error={error} />
 

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/use-doc-preview-binary.test.ts

@@ -0,0 +1,96 @@
+/**
+ * @vitest-environment node
+ */
+import { describe, expect, it } from 'vitest'
+import { resolveDocPreviewBinary } from './use-doc-preview-binary'
+
+function buffer(byte: number): ArrayBuffer {
+  return new Uint8Array([byte]).buffer
+}
+
+describe('resolveDocPreviewBinary', () => {
+  it('reports empty when nothing is committed and no binary has resolved', () => {
+    const result = resolveDocPreviewBinary({
+      data: undefined,
+      isPlaceholderData: false,
+      error: null,
+      lastGood: null,
+      hasCommittedContent: false,
+    })
+
+    expect(result.state).toBe('empty')
+    expect(result.data).toBeNull()
+    expect(result.error).toBeNull()
+  })
+
+  it('reports loading when committed but the first fetch has not resolved', () => {
+    const result = resolveDocPreviewBinary({
+      data: undefined,
+      isPlaceholderData: false,
+      error: null,
+      lastGood: null,
+      hasCommittedContent: true,
+    })
+
+    expect(result.state).toBe('loading')
+    expect(result.data).toBeNull()
+  })
+
+  it('reports ready and advances the head on a fresh success', () => {
+    const fresh = buffer(1)
+    const result = resolveDocPreviewBinary({
+      data: fresh,
+      isPlaceholderData: false,
+      error: null,
+      lastGood: null,
+      hasCommittedContent: true,
+    })
+
+    expect(result.state).toBe('ready')
+    expect(result.data).toBe(fresh)
+    expect(result.lastGood).toBe(fresh)
+  })
+
+  it('holds the previous binary as stale while a new version is fetching', () => {
+    const previous = buffer(1)
+    const result = resolveDocPreviewBinary({
+      data: previous,
+      isPlaceholderData: true,
+      error: null,
+      lastGood: previous,
+      hasCommittedContent: true,
+    })
+
+    expect(result.state).toBe('stale')
+    expect(result.data).toBe(previous)
+  })
+
+  it('falls back to the last good binary and suppresses the error after a failed refetch', () => {
+    const previous = buffer(1)
+    const result = resolveDocPreviewBinary({
+      data: undefined,
+      isPlaceholderData: false,
+      error: new Error('boom'),
+      lastGood: previous,
+      hasCommittedContent: true,
+    })
+
+    expect(result.state).toBe('stale')
+    expect(result.data).toBe(previous)
+    expect(result.error).toBeNull()
+  })
+
+  it('surfaces the error only when there is no binary to fall back to', () => {
+    const err = new Error('missing artifact')
+    const result = resolveDocPreviewBinary({
+      data: undefined,
+      isPlaceholderData: false,
+      error: err,
+      lastGood: null,
+      hasCommittedContent: true,
+    })
+
+    expect(result.data).toBeNull()
+    expect(result.error).toBe(err)
+  })
+})