fix(rich-editor): address review feedback on modal field

- RichMarkdownField reports the original value when the doc matches its canonical
  form, so a non-canonical input never reads as a false unsaved change (skill +
  version description modals)
- Add sim: mention link navigation (Cmd/Ctrl-click) to the modal field
- versions: keep the v{n} fallback as the rename guard/seed so re-submitting the
  displayed token is a no-op (no redundant "v3 · v3"); document the clear-name no-op
- Clarify the lazy query-gating comment in useMarkdownMentions

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/mention/use-markdown-mentions.ts

@@ -20,7 +20,9 @@ export function useMarkdownMentions(
   options: { enabled: boolean }
 ): MentionItem[] {
   const active = options.enabled && Boolean(workspaceId)
-  // Pass through only when active; each hook self-gates on a falsy workspaceId.
+  // When inactive, `ws` is undefined and `wsStr` is '' so every query stays disabled until the first
+  // `@`: the hooks that expose an `enabled` option get it explicitly; the rest (which take no options)
+  // self-gate internally on the falsy workspaceId — both empty string and undefined read as disabled.
   const ws = active ? workspaceId : undefined
   const wsStr = ws ?? ''
 

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-field.tsx

@@ -3,6 +3,7 @@
 import { useEffect, useRef, useState } from 'react'
 import type { JSONContent } from '@tiptap/core'
 import { EditorContent, useEditor } from '@tiptap/react'
+import { useRouter } from 'next/navigation'
 import { chipFieldSurfaceClass } from '@/components/emcn'
 import { cn } from '@/lib/core/utils/cn'
 import { createMarkdownEditorExtensions } from './extensions'
@@ -12,9 +13,10 @@ import {
   splitFrontmatter,
 } from './markdown-fidelity'
 import { parseMarkdownToDoc } from './markdown-parse'
-import { useEditorMentions } from './mention'
+import { parseSimHref, simLinkPath, useEditorMentions } from './mention'
 import { EditorBubbleMenu } from './menus/bubble-menu'
 import { LinkHoverCard } from './menus/link-hover-card'
+import { normalizeMarkdownContent } from './normalize-content'
 import '@/components/emcn/components/code/code.css'
 import './rich-markdown-editor.css'
 
@@ -64,6 +66,9 @@ export function RichMarkdownField({
   onPasteText,
 }: RichMarkdownFieldProps) {
   const containerRef = useRef<HTMLDivElement>(null)
+  const router = useRouter()
+  const routerRef = useRef(router)
+  routerRef.current = router
 
   // Frontmatter is held out-of-band and re-attached on serialize, exactly like the file editor.
   // Split once at mount — the refs and the seed doc all derive from the initial value.
@@ -76,6 +81,12 @@ export function RichMarkdownField({
   const onPasteTextRef = useRef(onPasteText)
   onPasteTextRef.current = onPasteText
 
+  // The original value verbatim, plus its canonical serialization. The editor only ever emits canonical
+  // markdown, so an already-non-canonical input would re-serialize on mount and read as an unsaved edit;
+  // reporting the original when the doc matches its canonical form keeps the field clean until a real edit.
+  const initialValueRef = useRef(value)
+  const [canonicalSeed] = useState(() => normalizeMarkdownContent(value))
+
   // TipTap extensions are stateful — build them once per mount so each field gets its own placeholder.
   const [extensions] = useState(() => createMarkdownEditorExtensions({ placeholder }))
   const [initialContent] = useState<JSONContent>(() => parseMarkdownToDoc(initialSplit.body))
@@ -96,11 +107,23 @@ export function RichMarkdownField({
         if (!text) return false
         return handler(text)
       },
+      handleClick: (view, _pos, event) => {
+        // Cmd/Ctrl-click an `@`-mention link to navigate to the resource (a plain click places the caret).
+        const href = (event.target as HTMLElement | null)?.closest('a')?.getAttribute('href')
+        if (!href?.startsWith('sim:') || !workspaceId) return false
+        if (view.editable && !(event.metaKey || event.ctrlKey)) return false
+        const parsed = parseSimHref(href)
+        const path = parsed && simLinkPath(workspaceId, parsed.kind, parsed.id)
+        if (!path) return false
+        routerRef.current.push(path)
+        return true
+      },
     },
     onUpdate: ({ editor }) => {
       const md = postProcessSerializedMarkdown(editor.getMarkdown())
       lastSyncedBodyRef.current = md
-      onChangeRef.current(applyFrontmatter(frontmatterRef.current, md))
+      const serialized = applyFrontmatter(frontmatterRef.current, md)
+      onChangeRef.current(serialized === canonicalSeed ? initialValueRef.current : serialized)
     },
   })
 

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/components/general/components/versions.tsx

@@ -73,18 +73,20 @@ export function Versions({
   const handleStartRename = (version: number, currentName: string | null | undefined) => {
     setOpenDropdown(null)
     setEditingVersion(version)
-    setEditValue(currentName ?? '')
+    setEditValue(currentName || `v${version}`)
   }
 
   const handleSaveRename = (version: number) => {
     if (renameMutation.isPending) return
+    // Clearing the name is a no-op — the version number is always the canonical reference.
     if (!workflowId || !editValue.trim()) {
       setEditingVersion(null)
       return
     }
 
     const currentVersion = versions.find((v) => v.version === version)
-    const currentName = currentVersion?.name ?? ''
+    // Compare against the `v{n}` fallback so re-submitting the displayed token saves no redundant name.
+    const currentName = currentVersion?.name || `v${version}`
 
     if (editValue.trim() === currentName) {
       setEditingVersion(null)
@@ -251,7 +253,6 @@ export function Versions({
                       }}
                       onClick={(e) => e.stopPropagation()}
                       onBlur={() => handleSaveRename(v.version)}
-                      placeholder={`v${v.version}`}
                       className={cn(
                         'h-auto w-full border-0 bg-transparent p-0 font-medium text-[var(--text-primary)] text-caption leading-5 shadow-none outline-none focus:outline-none focus-visible:ring-0'
                       )}