Commit dc80202
fix: apply the client timeout to reading, not just connecting
HomeDepotTest failed 4 of the last 7 CI runs, always the same way:
SerpApiException: java.net.http.HttpTimeoutException: request timed out
SerpApi.timeout was wired only to setHttpConnectionTimeout, so the read
timeout was never configured and kept SerpApiHttp's 60s default. That is
backwards: a 60s connection timeout is meaningless, since connecting
takes milliseconds, while 60s to read is tight for engines that scrape.
Apply the timeout to both, and raise the default to 120s, which the
home_depot engine regularly needs.
This is a library fix rather than a test fix: any caller searching a slow
engine hit the same timeout.
Also repair the README snippet helper, which sliced examples at a
hardcoded lines[23..], assuming every example body starts at line 24.
Quarantining GoogleEventsTest shifted that file and pulled the @ignore
and its comment into the docs as if they were usage code. Anchor on the
"// setup serpapi client" marker instead, which every example test has
exactly once, and regenerate.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 7913f2e commit dc80202
5 files changed
Lines changed: 45 additions & 6 deletions
File tree
- src
- main/java/serpapi
- test/java/serpapi
- example
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
444 | 444 | | |
445 | 445 | | |
446 | 446 | | |
447 | | - | |
| 447 | + | |
448 | 448 | | |
| 449 | + | |
449 | 450 | | |
450 | 451 | | |
451 | 452 | | |
| |||
492 | 493 | | |
493 | 494 | | |
494 | 495 | | |
495 | | - | |
496 | 496 | | |
497 | 497 | | |
498 | 498 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
4 | 8 | | |
5 | 9 | | |
6 | 10 | | |
7 | 11 | | |
8 | 12 | | |
9 | 13 | | |
10 | 14 | | |
11 | | - | |
| 15 | + | |
12 | 16 | | |
13 | 17 | | |
14 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
31 | 34 | | |
32 | | - | |
| 35 | + | |
33 | 36 | | |
34 | 37 | | |
35 | 38 | | |
| |||
40 | 43 | | |
41 | 44 | | |
42 | 45 | | |
| 46 | + | |
43 | 47 | | |
44 | 48 | | |
45 | 49 | | |
| |||
49 | 53 | | |
50 | 54 | | |
51 | 55 | | |
| 56 | + | |
52 | 57 | | |
53 | 58 | | |
54 | 59 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
Whitespace-only changes.
0 commit comments