Breaking: Remove hot from getTransformOptions (#2159)

Author: robhogan

docs/Configuration.md

@@ -598,7 +598,7 @@ When using React Native, `getTransformOptions` enables `inlineRequires` by defau
 ```flow
 function getTransformOptions(
   entryPoints: $ReadOnlyArray<string>,
-  options: {dev: boolean, hot: true, platform: ?string},
+  options: {dev: boolean, platform: ?string},
   getDependenciesOf: (path: string) => Promise<Array<string>>,
 ): Promise<ExtraTransformOptions> {
   // ...
@@ -608,7 +608,6 @@ function getTransformOptions(
 - **`entryPoints`**: Absolute paths to the bundle's [entry points](./Concepts.md#entry-point) (typically just one).
 - **`options`**:
   - **`dev`**: Whether the bundle is built in development mode.
-  - **`hot`**: <div class="label deprecated">Deprecated</div> Always true.
   - **`platform`**: The target platform (e.g. `ios`, `android`).
 - **`getDependenciesOf`**: Given a module's absolute path, resolves to the absolute paths of its transitive dependencies.
 

packages/metro-config/API.md

@@ -58,7 +58,6 @@ export type GetTransformOptions = (
 
 export type GetTransformOptionsOpts = {
   dev: boolean;
-  hot: true;
   platform: null | undefined | string;
 };
 

packages/metro-config/src/types.js

@@ -45,10 +45,6 @@ export type ExtraTransformOptions = Readonly<{
 
 export type GetTransformOptionsOpts = {
   dev: boolean,
-  /**
-   * @deprecated Always true
-   */
-  hot: true,
   platform: ?string,
 };
 

packages/metro/src/DeltaBundler/Serializers/getRamBundleInfo.js

@@ -156,7 +156,7 @@ async function _getRamOptions(
 
   const {preloadedModules, ramGroups} = await getTransformOptions(
     [entryFile],
-    {dev: options.dev, hot: true, platform: options.platform},
+    {dev: options.dev, platform: options.platform},
     async (x: string) => Array.from(getDependencies(x)),
   );
 

packages/metro/src/lib/transformHelpers.js

@@ -105,7 +105,7 @@ async function calcTransformerOptions(
 
   const {transform} = await config.transformer.getTransformOptions(
     entryFiles,
-    {dev: options.dev, hot: true, platform: options.platform},
+    {dev: options.dev, platform: options.platform},
     getDependencies,
   );